Fix network.transport and network.protocol issues in m365_defender #10418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt according to ECS. Added test logs to cover missing protocols and updated expected logs.
efd6
reviewed
Jul 9, 2024
Contributor
efd6
left a comment
There was a problem hiding this comment.
Please add a changelog entry and bump the patch version in manifest.yml.
Contributor
Author
|
Whoops forgot to do those. Should be updated @efd6! |
Contributor
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
Co-authored-by: Dan Kortschak <[email protected]>
Contributor
Author
|
Hey @efd6, is this good to go? |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
/test |
|
💚 Build Succeeded
History
|
|
Package m365_defender - 2.14.2 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The
network.transportandnetwork.protocolfields are not being set properly. Often the transport value (udp/tcp) is getting set to the protocol field and the protocol is never set at all. The changes I made to thetest-device.log-expected.jsonfile should demonstrate these issues.I also added handling for missing protocols and added example logs for the ones I had the ability to produce.
As a side note, I am happy to convert the entire logic for handling transport/protocol to a single script processor but I figured using the built in processors is easier for maintainability.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots