Skip to content

m365_defender network.transport bug #10730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 3 commits into from
Aug 8, 2024
Merged

m365_defender network.transport bug #10730

efd6 merged 3 commits into from
Aug 8, 2024

Conversation

@peterydzynski
Copy link
Contributor

@peterydzynski peterydzynski commented Aug 7, 2024 •
edited
Loading

Proposed commit message

On sslconnectioninspected events, the network.protocol field was getting set to dns. Updated processor to properly set the protocol to ssl.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@peterydzynski peterydzynski requested a review from a team as a code owner August 7, 2024 22:06
@cla-checker-service
Copy link

cla-checker-service bot commented Aug 7, 2024 •
edited
Loading

💚 CLA has been signed

@efd6
Copy link
Contributor

efd6 commented Aug 7, 2024

/test

@elasticmachine
Copy link

elasticmachine commented Aug 7, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Aug 7, 2024

💚 Build Succeeded

@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Aug 7, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

efd6
efd6 approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@efd6 efd6 merged commit 80576ff into elastic:main Aug 8, 2024
@elasticmachine
Copy link

elasticmachine commented Aug 8, 2024

Package m365_defender - 2.14.3 containing this change is available at https://epr.elastic.co/search?package=m365_defender

@peterydzynski peterydzynski deleted the protocol-bug branch August 8, 2024 14:03
@andrewkroh andrewkroh added Integration:m365_defender Microsoft Defender XDR bug Something isn't working, use only for issues labels Aug 12, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue and removed bug Something isn't working, use only for issues labels Aug 19, 2024
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@peterydzynski
m365_defender: set network.transport to ssl for ssl type actions (ela…
11521a6 
…stic#10730)

Co-authored-by: Peter Rydzynski <[email protected]>
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@peterydzynski
m365_defender: set network.transport to ssl for ssl type actions (ela…
212ceeb 
…stic#10730)

Co-authored-by: Peter Rydzynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

No one assigned

Labels

bugfix Pull request that fixes a bug issue Integration:m365_defender Microsoft Defender XDR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peterydzynski @efd6 @elasticmachine @andrewkroh