[M365 Defender] Fix handling of DNS answers field #10772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
reviewed
Aug 14, 2024
packages/m365_defender/data_stream/event/elasticsearch/ingest_pipeline/pipeline_device.yml
Outdated
Show resolved
Hide resolved
kcreddy
approved these changes
Aug 19, 2024
Contributor
kcreddy
left a comment
There was a problem hiding this comment.
Some nits. Otherwise LGTM 👍🏼
packages/m365_defender/data_stream/event/elasticsearch/ingest_pipeline/pipeline_device.yml
Outdated
Show resolved
Hide resolved
packages/m365_defender/data_stream/event/_dev/test/pipeline/test-device.log-expected.json
Show resolved
Hide resolved
packages/m365_defender/data_stream/event/elasticsearch/ingest_pipeline/pipeline_device.yml
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
History
|
|
|
Package m365_defender - 2.14.5 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
Fixes how the dns.answers ECS field is filled from the M365 Defender data. It was directly set from a keyword field so it was inheriting the same type, while ECS expects a JSON object. In addition, TTLs are also added to the dns.answers field.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
Fixes how the dns.answers ECS field is filled from the M365 Defender data. It was directly set from a keyword field so it was inheriting the same type, while ECS expects a JSON object. In addition, TTLs are also added to the dns.answers field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR fixes how the
dns.answersECS field is filled from the M365 Defender data. It was directly set from a keyword field so it was inheriting the same type, while ECS expects a JSON object.In addition, TTLs are also added to the
dns.answersfield.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots