M365_defender bug fix: add check for - in host.mac
#10798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
|
Package m365_defender - 2.14.4 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
M365 Defender has started to send logs where the MAC address already has '-'s. This breaks the gsub processor that is expecting the old format where MAC addresses have no '-'. Add a conditional check for this processor so that it only runs if it encounters a MAC address without '-'s in it.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
M365 Defender has started to send logs where the MAC address already has '-'s. This breaks the gsub processor that is expecting the old format where MAC addresses have no '-'. Add a conditional check for this processor so that it only runs if it encounters a MAC address without '-'s in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
M365 Defender has started to send logs where the MAC address already has
-'s. This breaks thegsubprocessor that is expecting the old format where MAC addresses have no-'s . I added a conditional check for this processor so that it only runs if it encounters a MAC address without-'s in it.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots