m365_defender: fix assignment of windows os identity and posix hosts #10953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5bd988 to
7d76f05
Compare
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
7d76f05 to
71473c5
Compare
Contributor
Author
|
Waiting for a bit to see about getting a WSL test case to include in testing. |
71473c5 to
2de1bd9
Compare
Contributor
Author
|
Note additional change here that affects POSIX hosts. See rationale in PR description. If this is too far, I'm happy to back out the second commit which makes this change. |
💚 Build Succeeded
History
cc @efd6 |
|
chemamartinez
approved these changes
Sep 16, 2024
|
Package m365_defender - 2.15.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
…lastic#10953) Ensure that windows hosts are not labelled as macos or linux by examining POSIX details fields. Also label otherwise unknown host types as unix if they do have a POSIX details on the basis that Windows hosts have already been excluded and so all remaining POSIX host types are Unix.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
…lastic#10953) Ensure that windows hosts are not labelled as macos or linux by examining POSIX details fields. Also label otherwise unknown host types as unix if they do have a POSIX details on the basis that Windows hosts have already been excluded and so all remaining POSIX host types are Unix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Ensure that windows hosts are not labelled as macos or linux by examining
POSIX details fields. Also label otherwise unknown host types as unix if they
do have a POSIX details on the basis that Windows hosts have already been
excluded and so all remaining POSIX host types are Unix.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
host.os.typeto windows for MacOS devices #10680Screenshots