crowdstrike: fix handling of network direction #12508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101bf00 to
d9ddf43
Compare
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy
reviewed
Jan 31, 2025
Contributor
kcreddy
left a comment
There was a problem hiding this comment.
It would be nice to hear from user on #12476 (comment)
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/outbound_network.yml
Outdated
Show resolved
Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/outbound_network.yml
Outdated
Show resolved
Hide resolved
packages/crowdstrike/data_stream/fdr/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
kcreddy
approved these changes
Feb 3, 2025
Contributor
Author
|
Waiting for @monkeyonbranch. Setting as draft to avoid accidental merge. |
9444961 to
77e1e98
Compare
Assume that network direction that is no inbound can be validly semantically represented as outbound using the ECS fields available. This is probably not true; documented values of the ConnectionDirection are 0 - outbound, 1 - inbound, 2 - neither, and 3 - both[1]. Adhering strictly to inbound/outbound makes it impossible to map the data to ECS since neither and both would only be expressible as unknown. [1]https://docs.panther.com/data-onboarding/supported-logs/crowdstrike/falcon-data-replicator#crowdstrike.networkconnect
77e1e98 to
07ef3af
Compare
💚 Build Succeeded
History
cc @efd6 |
|
Contributor
|
Sorry for the long wait. Sometimes life happens. |
Contributor
Author
|
Thanks @monkeyonbranch. If there are any issues with the heuristic we are using, please file a new issue. |
qcorporation
pushed a commit
that referenced
this pull request
Feb 5, 2025
Assume that network direction that is not inbound can be validly semantically represented as outbound using the ECS fields available. This is probably not true; documented values of the ConnectionDirection are 0 - outbound, 1 - inbound, 2 - neither, and 3 - both[1]. Adhering strictly to inbound/outbound makes it impossible to map the data to ECS since neither and both would only be expressible as unknown. [1]https://docs.panther.com/data-onboarding/supported-logs/crowdstrike/falcon-data-replicator#crowdstrike.networkconnect
JoseLuisGJ
pushed a commit
to JoseLuisGJ/integrations
that referenced
this pull request
Feb 6, 2025
Assume that network direction that is not inbound can be validly semantically represented as outbound using the ECS fields available. This is probably not true; documented values of the ConnectionDirection are 0 - outbound, 1 - inbound, 2 - neither, and 3 - both[1]. Adhering strictly to inbound/outbound makes it impossible to map the data to ECS since neither and both would only be expressible as unknown. [1]https://docs.panther.com/data-onboarding/supported-logs/crowdstrike/falcon-data-replicator#crowdstrike.networkconnect
|
Package crowdstrike - 1.49.1 containing this change is available at https://epr.elastic.co/package/crowdstrike/1.49.1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Assume that network direction that is no inbound can be validly semantically represented as outbound using the ECS fields available. This is probably not true; documented values of the ConnectionDirection are 0 - outbound, 1 - inbound, 2 - neither, and 3 - both[1].
Adhering strictly to inbound/outbound makes it impossible to map the data to ECS since neither and both would only be expressible as unknown.
[1]https://docs.panther.com/data-onboarding/supported-logs/crowdstrike/falcon-data-replicator#crowdstrike.networkconnect
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots