Skip to content

Conversation

@Alphayeeeet
Copy link
Contributor

Label as enhancement

Proposed commit message

Remove event.original removal processors

Related issues

Review #10072 for additional info
This should be the final PR and therefore should close #10072 after all other PR's have been merged

@Alphayeeeet Alphayeeeet requested review from a team as code owners April 12, 2025 10:42
@andrewkroh andrewkroh added Integration:spring_boot Spring Boot Integration:salesforce Salesforce Integration:sophos Sophos Integration:modsecurity ModSecurity Audit (Community supported) Integration:qnap_nas QNAP NAS (Community supported) Integration:sysmon_linux Sysmon for Linux Integration:vsphere VMware vSphere Integration:system System Integration:stan STAN Integration:osquery Osquery Logs Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Apr 14, 2025
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

conditions:
kibana:
version: "^7.16.0 || ^8.0.0 || ^9.0.0"
version: "^8.11.0 || ^9.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the support for 7.6.0 here ? I think we should discuss with the codeowners if we are ok to do that

@Alphayeeeet
Copy link
Contributor Author

@ishleenk17 As stated out in multiple PR's for this issue, the removal of the support is necessary to fulfil the change, as the necessary changes in the fleet-final-pipeline were introduced in 8.11.0 so any lower versions cannot be supported anymore.

Please view the linked issue for reference: #10072

@Alphayeeeet Alphayeeeet requested a review from ishleenk17 April 29, 2025 10:03
@Alphayeeeet
Copy link
Contributor Author

@ishleenk17 Could you by any chance re-do your review? If approved, I will resolve the conflicts to ensure CI tests run through afterwards.

@Alphayeeeet
Copy link
Contributor Author

@ishleenk17 Please re-review the PR and run tests. Thanks

@Alphayeeeet
Copy link
Contributor Author

@ishleenk17 Any updates on when this gets reviewed again?

Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ishleenk17
Copy link
Member

/test

@ishleenk17 ishleenk17 enabled auto-merge (squash) June 13, 2025 10:07
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 13, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

auto-merge was automatically disabled June 13, 2025 12:16

Head branch was pushed to by a user without write access

@Alphayeeeet
Copy link
Contributor Author

@andrewkroh or @ishleenk17 Please run CI again

@taylor-swanson
Copy link
Contributor

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube
Copy link

@taylor-swanson taylor-swanson merged commit 94bef55 into elastic:main Jun 13, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package modsecurity - 1.21.0 containing this change is available at https://epr.elastic.co/package/modsecurity/1.21.0/

@elastic-vault-github-plugin-prod

Package osquery - 1.23.0 containing this change is available at https://epr.elastic.co/package/osquery/1.23.0/

@elastic-vault-github-plugin-prod

Package qnap_nas - 1.23.0 containing this change is available at https://epr.elastic.co/package/qnap_nas/1.23.0/

@elastic-vault-github-plugin-prod

Package salesforce - 1.2.0 containing this change is available at https://epr.elastic.co/package/salesforce/1.2.0/

@elastic-vault-github-plugin-prod

Package sophos - 3.14.0 containing this change is available at https://epr.elastic.co/package/sophos/3.14.0/

@elastic-vault-github-plugin-prod

Package spring_boot - 1.9.0 containing this change is available at https://epr.elastic.co/package/spring_boot/1.9.0/

@elastic-vault-github-plugin-prod

Package stan - 1.11.0 containing this change is available at https://epr.elastic.co/package/stan/1.11.0/

@elastic-vault-github-plugin-prod

Package sysmon_linux - 1.9.0 containing this change is available at https://epr.elastic.co/package/sysmon_linux/1.9.0/

@elastic-vault-github-plugin-prod

Package system - 2.3.0 containing this change is available at https://epr.elastic.co/package/system/2.3.0/

@elastic-vault-github-plugin-prod

Package vsphere - 1.19.0 containing this change is available at https://epr.elastic.co/package/vsphere/1.19.0/

@Alphayeeeet Alphayeeeet deleted the remove-event.original6 branch July 14, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:modsecurity ModSecurity Audit (Community supported) Integration:osquery Osquery Logs Integration:qnap_nas QNAP NAS (Community supported) Integration:salesforce Salesforce Integration:sophos Sophos Integration:spring_boot Spring Boot Integration:stan STAN Integration:sysmon_linux Sysmon for Linux Integration:system System Integration:vsphere VMware vSphere Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] Team:Security-Linux Platform Linux Platform Security team [elastic/sec-linux-platform]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove event.original removal processors from ingest pipelines

6 participants