Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Aug 3, 2025

Proposed commit message

m365_defender,microsoft_defender_endpoint: fix handling of empty and error results in vulnerability data stream

Also clean up CEL code to improve clarity.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Aug 3, 2025
@efd6 efd6 added Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Integration:m365_defender Microsoft Defender XDR bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Aug 3, 2025
@efd6 efd6 force-pushed the s6256-microsoft_defender branch from 69bb710 to 2ee712e Compare August 3, 2025 23:47
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

Package m365_defender 👍(3) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
event 768.64 613.12 -155.52 (-20.23%) 💔

Package microsoft_defender_endpoint 👍(1) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 3521.13 2638.52 -882.61 (-25.07%) 💔
machine_action 6622.52 4651.16 -1971.36 (-29.77%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube
Copy link

@efd6 efd6 marked this pull request as ready for review August 4, 2025 00:23
@efd6 efd6 requested a review from a team as a code owner August 4, 2025 00:23
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 05324a3 into elastic:main Aug 5, 2025
9 checks passed
@elastic-vault-github-plugin-prod

Package m365_defender - 3.14.1 containing this change is available at https://epr.elastic.co/package/m365_defender/3.14.1/

@elastic-vault-github-plugin-prod

Package microsoft_defender_endpoint - 2.42.1 containing this change is available at https://epr.elastic.co/package/microsoft_defender_endpoint/2.42.1/

robester0403 pushed a commit to robester0403/integrations that referenced this pull request Aug 14, 2025
…error results in vulnerability data stream (elastic#14783)

Also clean up CEL code to improve clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:m365_defender Microsoft Defender XDR Integration:microsoft_defender_endpoint Microsoft Defender for Endpoint Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants