-
Notifications
You must be signed in to change notification settings - Fork 522
[Akamai SIEM] - Fixed pagination logic to use the number_of_events_returned >= event_limit conditional check instead of offset presence #16225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rémy suggests
akamai: fix pagination logic to use limit field instead of offset
The integration was incorrectly using the offset field for pagination,
which caused issues with data retrieval. The Akamai SIEM API requires
the limit field for proper pagination control.
Documentation: https://techdocs.akamai.com/siem-integration/reference/offsetcontext
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please wait for @andrewkroh
|
@andrewkroh, made the suggested change, let me know if it's good to merge or not atm. |
💚 Build Succeeded
History
cc @ShourieG |
|
Package akamai - 3.0.1 containing this change is available at https://epr.elastic.co/package/akamai/3.0.1/ |
Type of change
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots