Skip to content

Fix hashicorp documentation #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bmorelli25 merged 4 commits into from
Feb 9, 2022
Merged

Fix hashicorp documentation #2655

bmorelli25 merged 4 commits into from
Feb 9, 2022

Conversation

@bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Feb 9, 2022 •
edited
Loading

Summary

The Hashicorp Vault readme is breaking the integration documentation update script. This PR fixes the error by moving indented code to markdown code blocks. This prevents the build from trying to render < and { characters.

Related

Other PRs that I have opened with similar problems:

@bmorelli25 bmorelli25 added the Team:Docs Label for the Observability docs team label Feb 9, 2022
@bmorelli25 bmorelli25 self-assigned this Feb 9, 2022
This was referenced Feb 9, 2022
Merged
Merged
@elasticmachine
Copy link

elasticmachine commented Feb 9, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-09T00:49:10.659+0000

  • Duration: 25 min 20 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@bmorelli25 bmorelli25 mentioned this pull request Feb 9, 2022
Closed
1 task
bmorelli25
bmorelli25 commented Feb 9, 2022
View reviewed changes
andrewkroh
andrewkroh approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25
Copy link
Member Author

bmorelli25 commented Feb 9, 2022

Thanks, Andrew!

@bmorelli25 bmorelli25 merged commit 2b8b478 into elastic:main Feb 9, 2022
@bmorelli25 bmorelli25 deleted the fix-hashicorp branch February 9, 2022 03:30
@andrewkroh andrewkroh mentioned this pull request Feb 9, 2022
Merged
@bmorelli25 bmorelli25 mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@marc-gr marc-gr Awaiting requested review from marc-gr

Assignees

@bmorelli25 bmorelli25

Labels

Team:Docs Label for the Observability docs team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bmorelli25 @elasticmachine @andrewkroh