Skip to content

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 4, 2022

What does this PR do?

Remove named mappings and depend on the dynamic mappings. Dynamic mappings
were already present, but elastic-package doesn't honor those during field validation.
So this specifies a hashicorp_vault.metrics.*.* mapping for the express purpose of making
elastic-package field validation pass.

Fixes #2898

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:hashicorp_vault Hashicorp Vault labels Apr 4, 2022
@andrewkroh andrewkroh requested a review from a team as a code owner April 4, 2022 20:48
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Remove named mappings and depend on the dynamic mappings. Dynamic mappings
were already present, but elastic-package doesn't honor those during field validation.
So this specifies a hashicorp_vault.metrics.*.* mapping for the express purpose of making
elastic-package field validation pass.

Fixes #2898
@elasticmachine
Copy link

elasticmachine commented Apr 4, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-04T20:49:55.123+0000

  • Duration: 17 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:hashicorp_vault Hashicorp Vault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[hashicorp_vault] undefined metric fields detected by tests

3 participants