Skip to content

Conversation

@colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented May 25, 2022

What does this PR do?

From https://github.com/elastic/observability-docs/issues/1019:

Let's audit the documentation for our top 5 integrations. The descriptions can be improved so users have a better understanding of what benefit they offer, how Elastic can help with the user's use case, and persuade them to install the integration.

This PR proposes updated and more detailed documentation guidelines based on my experience adding context to the top five integrations in #3306, #3352, #3308, #3359, and #3393.

Guidelines like this can help standardize the structure and language across integrations, which may reduce friction for users who are interested in using more than one integration. But, they are also just guidelines and can be altered on a case-by-case basis as needed.

For the reviewer

  • I'm open to any and all feedback on these guidelines! I am definitely not the expert on integrations -- I've mostly worked with the top five integrations (and a handful of others) -- so your input is critical!
  • Do you agree with the goals stated at the beginning?
  • Would it be helpful to work together on a list of assumptions we're comfortable making about the reader? For example, can we assume that they are familiar with Elastic and have created a deployment, but haven't used an integration before?
  • I'm not sure what the true list of data types should be (logs, metrics, others?).

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Related issues

@colleenmcginnis colleenmcginnis added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Docs Label for the Observability docs team labels May 25, 2022
@colleenmcginnis colleenmcginnis self-assigned this May 25, 2022
@colleenmcginnis
Copy link
Contributor Author

@bmorelli25 do you want to take a first look and then tag in others who should review?

@elasticmachine
Copy link

elasticmachine commented May 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-30T09:25:36.155+0000

  • Duration: 103 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 5194
Skipped 7
Total 5201

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 26, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (265/265) 💚
Files 96.599% (426/441) 👍
Classes 96.599% (426/441) 👍
Methods 88.845% (4484/5047) 👍 0.095
Lines 89.947% (80975/90025) 👍
Conditionals 100.0% (0/0) 💚

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this document does a great job outlining the structure you came up with for https://github.com/elastic/observability-docs/issues/1019.

Like DeDe mentioned in today's meeting, and once the dev team weighs in, it'd be great to eventually automate the creation of a readme template. In the meantime, it might help to add a complete template to these docs that can easily be copy/pasted.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review June 1, 2022 18:41
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner June 1, 2022 18:41
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Added some comments about the use of "data types" terms.

@colleenmcginnis
Copy link
Contributor Author

@jamiehynds can you please take a look at these proposed guidelines? Thanks!

colleenmcginnis added a commit to colleenmcginnis/integrations that referenced this pull request Jun 6, 2022
colleenmcginnis added a commit to colleenmcginnis/integrations that referenced this pull request Jun 6, 2022
@ruflin ruflin requested a review from akshay-saraswat June 7, 2022 13:02
colleenmcginnis added a commit to colleenmcginnis/integrations that referenced this pull request Jun 7, 2022
colleenmcginnis added a commit to colleenmcginnis/integrations that referenced this pull request Jun 7, 2022
colleenmcginnis added a commit to colleenmcginnis/integrations that referenced this pull request Jun 7, 2022
colleenmcginnis added a commit that referenced this pull request Jun 21, 2022
* first draft of system integration edits

wording

* update changelog, update manifest, build README

* clean up changelog.yml

* address feedback from @bmorelli25

* align with guidelines in #3433
colleenmcginnis added a commit that referenced this pull request Jun 21, 2022
* first draft of aws integration edits

* update changelog, update manifest, build README

* actually build READMEs

* address feedback from @bmorelli25

* remove relative links

* updated generated READMEs

* address feedback on build errors

* align with guidelines in #3433

update generated docs

* address feedback from @kaiyan-sheng
colleenmcginnis added a commit that referenced this pull request Jun 21, 2022
* first draft of windows integration edits

* update changelog, update manifest, build README

* address initial feedback

* address feedback from @andrewkroh

* align with guidelines in #3433
colleenmcginnis added a commit that referenced this pull request Jun 21, 2022
* first draft of linux metrics integration edits

* Update packages/linux/changelog.yml

* align with guidelines in #3433
@colleenmcginnis
Copy link
Contributor Author

Thanks for your comments @jamiehynds! There are a few remaining comments to be resolved, but I don't have enough context to propose general language/guidelines for them. Do you want to continue iterating here or accept the current guidelines and open issues to track the remaining comments?

@jamiehynds
Copy link

Thanks for your comments @jamiehynds! There are a few remaining comments to be resolved, but I don't have enough context to propose general language/guidelines for them. Do you want to continue iterating here or accept the current guidelines and open issues to track the remaining comments?

Sorry for the delay here @colleenmcginnis. I think I've responded to the outstanding comments. If you prefer to close this issue and open issues to track any remaining comments, totally fine with me.

@colleenmcginnis
Copy link
Contributor Author

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Great work, @colleenmcginnis.

@jsoriano
Copy link
Member

/test

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colleenmcginnis colleenmcginnis merged commit 7a17e3b into elastic:main Jun 30, 2022
@colleenmcginnis colleenmcginnis deleted the top-five-audit-guidelines branch June 30, 2022 15:18
colleenmcginnis added a commit that referenced this pull request Jul 7, 2022
* first draft of nginx integration edits

* add pr link

* align with guidelines in #3433

* address feedback from @ishleenk17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Team:Docs Label for the Observability docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants