Skip to content

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Nov 15, 2022

What does this PR do?

Similar to #4567, this PR is to remove all duplicate fields from agent.yml files from all data streams under AWS package and use ecs.yml file to document all ECS fields to avoid re-defining these fields again.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner November 15, 2022 22:32
@kaiyan-sheng kaiyan-sheng changed the title [AWS] Remove duplicate fields from agent.yml and use ecs.yml for all ECS fi… [AWS] Remove duplicate fields from agent.yml and use ecs.yml for ECS fields Nov 15, 2022
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-15T22:34:53.830+0000

  • Duration: 34 min 21 sec

Test stats 🧪

Test Results
Failed 0
Passed 162
Skipped 2
Total 164

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (13/13) 💚
Files 92.857% (13/14) 👎 -4.829
Classes 92.857% (13/14) 👎 -4.829
Methods 84.232% (203/241) 👎 -7.037
Lines 95.697% (5204/5438) 👍 3.992
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .md files in docs mostly have a few description changes, but it's probably due to the switch to the ECS field definitions.

LGTM.

@kaiyan-sheng
Copy link
Contributor Author

@zmoog Yep exactly :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants