-
Notifications
You must be signed in to change notification settings - Fork 522
[m365_defender] Add support for Streaming Event types #4962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
🌐 Coverage report
|
packages/m365_defender/data_stream/event/_dev/test/pipeline/test-alert.log-expected.json
Outdated
Show resolved
Hide resolved
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to have the technique.subtechnique arrays canonicalised since map iteration order is not guaranteed to be consistent.
packages/m365_defender/data_stream/event/elasticsearch/ingest_pipeline/pipeline_alert.yml
Show resolved
Hide resolved
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay; LGTM
|
Hey @efd6 - Would you mind holding on to the merge for a bit? Jamie and I are to discuss a couple of approaches to disable the deprecated data stream by default. And I might add a commit along with this PR. Sorry for the inconvenience, I will let you know once we discuss the strategy. 😄 |
985a12f to
113f0b0
Compare
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
|
Package m365_defender - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender |
What does this PR do?
Checklist
changelog.ymlfile.manifest.ymlfile to point to the latest Elastic stack release (e.g.^7.16.0 || ^8.0.0).How to test this PR locally
Screenshots