Skip to content

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Apr 8, 2023

What does this PR do?

Add an advanced option to enable http request trace logging for debugging purposes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. elastic-package build
  2. elastic-package install
  3. Use Kibana to add the integration to an Agent policy and toggle on the tracer feature.
  4. Verify request/response logs are in /usr/share/elastic-agent/state/data/run/httpjson-default/http-request-trace-httpjson*.ndjson.

@andrewkroh andrewkroh added enhancement New feature or request Team:Security-External Integrations Integration:akamai Akamai (Community supported) labels Apr 8, 2023
Add an advanced option to enable http request trace logging for
debugging purposes.

Bump kibana constraint to 8.5.0 which is when the request
tracer feature was introduced to Agent.
@andrewkroh andrewkroh marked this pull request as ready for review April 8, 2023 11:21
@andrewkroh andrewkroh requested a review from a team as a code owner April 8, 2023 11:21
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 8, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-08T11:21:49.772+0000

  • Duration: 15 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.177
Classes 100.0% (1/1) 💚 3.177
Methods 100.0% (20/20) 💚 7.931
Lines 93.229% (358/384) 👍 1.954
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkroh andrewkroh merged commit 18eb8e3 into elastic:main Apr 8, 2023
@elasticmachine
Copy link

Package akamai - 2.6.0 containing this change is available at https://epr.elastic.co/search?package=akamai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:akamai Akamai (Community supported)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants