akamai: fix signs of from and to GET parameters #6384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial_interval manifest option is an unsigned interval, represented as a postive time offset, but the url.params.from template was adding it unaltered to the now time, resulting in a "from" in the future. Similarly, the url.params.to template was calculating now less one minute. Fix the "from" sign and don't offset the "to" time.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
kgeller
approved these changes
May 31, 2023
andrewkroh
approved these changes
May 31, 2023
Member
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM. I checked the requests in the system tests and they were:
- http://elastic-package-service_akamai_1:8080/siem/v1/configs/aaaa?from=1685461569&to=1685547969
- http://elastic-package-service_akamai_1:8080/siem/v1/configs/aaaa?offset=offset1
- http://elastic-package-service_akamai_1:8080/siem/v1/configs/aaaa?offset=offset2
1685547969 - 1685461569 = 86400 sec = 24h ✅
|
Package akamai - 2.9.1 containing this change is available at https://epr.elastic.co/search?package=akamai |
agithomas
pushed a commit
to agithomas/integrations
that referenced
this pull request
Jun 5, 2023
The initial_interval manifest option is an unsigned interval, represented as a postive time offset, but the url.params.from template was adding it unaltered to the now time, resulting in a "from" in the future. Similarly, the url.params.to template was calculating now less one minute. Fix the "from" sign and don't offset the "to" time.
sodhikirti07
pushed a commit
that referenced
this pull request
Jun 15, 2023
The initial_interval manifest option is an unsigned interval, represented as a postive time offset, but the url.params.from template was adding it unaltered to the now time, resulting in a "from" in the future. Similarly, the url.params.to template was calculating now less one minute. Fix the "from" sign and don't offset the "to" time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The initial_interval manifest option is an unsigned interval, represented as a postive time offset, but the url.params.from template was adding it unaltered to the now time, resulting in a "from" in the future. Similarly, the url.params.to template was calculating now less one minute. Fix the "from" sign and don't offset the "to" time.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots
References