Skip to content

Conversation

@agithomas
Copy link
Contributor

Type of Change

  • Enhancement

What does this PR do?

Add dimension mapping to info datastream of HA Proxy

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry
  • Dashboard validation
  • Index and Index template validation

Related issues

@elasticmachine
Copy link

elasticmachine commented Aug 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-11T09:49:13.861+0000

  • Duration: 15 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 1, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 90.476% (19/21) 👍 17.143
Lines 97.297% (180/185) 👎 -2.703
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor Author

image

@agithomas agithomas mentioned this pull request Aug 1, 2023
20 tasks
@agithomas agithomas marked this pull request as ready for review August 1, 2023 10:50
@agithomas agithomas requested a review from a team as a code owner August 1, 2023 10:51
@agithomas
Copy link
Contributor Author

image

@agithomas agithomas requested a review from ritalwar August 9, 2023 05:32
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor Author

/test

@agithomas agithomas merged commit 01c94bf into elastic:main Aug 12, 2023
@elasticmachine
Copy link

Package haproxy - 1.8.2 containing this change is available at https://epr.elastic.co/search?package=haproxy

@agithomas agithomas deleted the issue-7138-haproxy-dimensions-info branch February 12, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants