aws: fix GuardDuty API call parameter #7785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS documentation specifies that the maxResults parameter be
droopingCamelCase[1], while we are using CamelCase. This results in API
requests being rejected with the following error
{
"message": "The request is rejected because the JSON could not be processed.",
"__type": "InvalidInputException"
}
[1]https://docs.aws.amazon.com/guardduty/latest/APIReference/API_ListFindings.html
The skip was in place because we were testing on versions below 8.6. The kibana version is now v8.9.0, so we can re-enable it.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
zmoog
approved these changes
Sep 13, 2023
Contributor
zmoog
left a comment
There was a problem hiding this comment.
LGTM. Kudos for the clear and complete PR description.
andrewkroh
approved these changes
Sep 13, 2023
|
Package aws - 2.2.1 containing this change is available at https://epr.elastic.co/search?package=aws |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The AWS documentation specifies that the maxResults parameter be
droopingCamelCase, while we are using CamelCase. This results in API
requests being rejected with the following error
Also re-enable system tests for the data stream; the skip was in
place because we were testing on versions below 8.6. The kibana
version is now v8.9.0, so we can re-enable it.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots