Update orignal osquery package description #825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Steps errors
Expand to view the steps failures
|
melissaburpo
reviewed
Apr 1, 2021
Contributor
melissaburpo
left a comment
There was a problem hiding this comment.
Looks good. I just had one comment/question.
packages/osquery/manifest.yml
Outdated
| @@ -1,8 +1,8 @@ | |||
| name: osquery | |||
| title: Osquery | |||
Contributor
There was a problem hiding this comment.
Should the title be updated to Osquery Log Collection too? Is that the field used for titles shown on the Integration list page, or is another field used for that?
melissaburpo
reviewed
Apr 1, 2021
|
|
||
| ## Compatibility | ||
|
|
||
| The OSQuery integration was tested with logs from osquery version 2.10.2. |
Contributor
There was a problem hiding this comment.
I just noticed this one last reference to the original name. Should update here too:
OSQuery integration --> Osquery Log Collection integration
melissaburpo
approved these changes
Apr 1, 2021
mtojek
reviewed
Apr 1, 2021
Contributor
mtojek
left a comment
There was a problem hiding this comment.
Conceptually this change looks absolutely valid. Please just address posted comments.
packages/osquery/docs/README.md
Outdated
| @@ -1,14 +1,16 @@ | |||
| # OSQuery Integration | |||
| # Osquery Log Collection | |||
Contributor
There was a problem hiding this comment.
Could you please update the doc template file first https://github.com/elastic/integrations/blob/38a2b326c8b1c08294a5a59faa2c56e94e92194f/packages/osquery/_dev/build/docs/README.md and then build the integration? elastic-package build
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "0.1.2" | |||
Contributor
There was a problem hiding this comment.
I suppose this one may need formatting (elastic-package format).
Contributor
Author
|
Thanks @mtojek I used elastic-package to build / format. :) |
mtojek
approved these changes
Apr 2, 2021
Contributor
mtojek
left a comment
There was a problem hiding this comment.
Errors are unrelated to this PR. You should be good to go.
Contributor
Author
|
Thanks @mtojek, I don't have the permission to merge this, could you do it for me? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots