Skip to content

Conversation

@agithomas
Copy link
Contributor

@agithomas agithomas commented Oct 26, 2023

  • Enhancement

Proposed commit message

  • WHAT : Enable time series data streams for the metrics datasets.
  • WHY : This improves storage usage and query performance.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Completed the data verification using TSDB Migration Toolkit

How to test this PR locally

elastic-package build
elastic-package stack up -v -d --services package-registry
Install / Update the package
Index settings and mapping verifications

Related issues

Screenshots

Package installation validation

image

Index settings validation

image

@elasticmachine
Copy link

elasticmachine commented Oct 26, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-26T11:57:33.170+0000

  • Duration: 18 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (3/3) 💚 3.837
Classes 100.0% (3/3) 💚 3.837
Methods 92.593% (25/27) 👍 0.495
Lines 87.85% (188/214) 👎 -0.758
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor Author

agithomas commented Oct 26, 2023

Dimension mappings

"labels": {
       "properties": {
         "auth_method": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "cluster": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "creation_ttl": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "expiring": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "gauge": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "host": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "instance": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "job": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "local": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "mount_point": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "namespace": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "policy": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "quantile": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "queue_id": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "term": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "token_type": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "type": {
           "type": "keyword",
           "time_series_dimension": true
         },
         "version": {
           "type": "keyword",
           "time_series_dimension": true
         }
       }
     },

@agithomas agithomas mentioned this pull request Oct 26, 2023
5 tasks
@agithomas agithomas marked this pull request as ready for review October 26, 2023 12:30
@agithomas agithomas requested a review from a team as a code owner October 26, 2023 12:30
@agithomas
Copy link
Contributor Author

agithomas commented Oct 26, 2023

TSDB Migration tool kit Output details can be found here

@andrewkroh andrewkroh added Integration:hashicorp_vault Hashicorp Vault enhancement New feature or request labels Oct 26, 2023
@agithomas agithomas merged commit 90ca120 into elastic:main Oct 30, 2023
@elasticmachine
Copy link

Package hashicorp_vault - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=hashicorp_vault

@agithomas agithomas deleted the issue-8128-tsdb-enablement branch February 12, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:hashicorp_vault Hashicorp Vault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants