Skip to content

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Feb 12, 2024

Proposed commit message

  • Set sensitive values in hashicorp_vault and zeek packages
  • Updated package-spec to 3.0.2 to leverage secrets validation checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package test

Related issues

  • Relates elastic/security-team#7388

- Set sensitive values in hashicorp_vault and zeek packages
@taylor-swanson taylor-swanson added enhancement New feature or request Integration:zeek Zeek Integration:hashicorp_vault Hashicorp Vault Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Feb 12, 2024
@taylor-swanson taylor-swanson self-assigned this Feb 12, 2024
@taylor-swanson taylor-swanson changed the title Set sensitive values as secret [hashicorp_vault,zeek] Set sensitive values as secret Feb 12, 2024
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@elasticmachine
Copy link

🚀 Benchmarks report

Package zeek 👍(13) 💚(22) 💔(8)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
intel 31250 26315.79 -4934.21 (-15.79%) 💔
kerberos 17241.38 12987.01 -4254.37 (-24.68%) 💔
known_services 45454.55 32258.06 -13196.49 (-29.03%) 💔
smb_files 19607.84 16129.03 -3478.81 (-17.74%) 💔
software 47619.05 40000 -7619.05 (-16%) 💔
dce_rpc 11235.96 6578.95 -4657.01 (-41.45%) 💔
weird 29411.76 22222.22 -7189.54 (-24.44%) 💔
dpd 17857.14 13888.89 -3968.25 (-22.22%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @taylor-swanson

@taylor-swanson taylor-swanson marked this pull request as ready for review February 12, 2024 17:38
@taylor-swanson taylor-swanson requested a review from a team as a code owner February 12, 2024 17:38
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taylor-swanson taylor-swanson merged commit b59f8d1 into elastic:main Feb 14, 2024
@taylor-swanson taylor-swanson deleted the feature/secret-values-dnd branch February 14, 2024 17:47
@elasticmachine
Copy link

Package hashicorp_vault - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=hashicorp_vault

@elasticmachine
Copy link

Package zeek - 2.23.0 containing this change is available at https://epr.elastic.co/search?package=zeek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:hashicorp_vault Hashicorp Vault Integration:zeek Zeek Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants