Skip to content

Conversation

@andrewkroh
Copy link
Member

Proposed commit message

Prevent the kv processor from executing on empty userRiskData.{risk,trust,general} values. This aims to address these observed errors:

field [json.userRiskData.trust] does not contain value_split[:]
field [json.userRiskData.risk] does not contain value_split[:]

This is also improving on the error.message to help track down additional bugs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Prevent the kv processor from executing on empty userRiskData.{risk,trust,general} values.
This aims to address these observed errors:

    field [json.userRiskData.trust] does not contain value_split[:]
    field [json.userRiskData.risk] does not contain value_split[:]
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Integration:akamai Akamai (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Apr 1, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

[git-generate]
cd packages/akamai
elastic-package changelog add --link #9483 --next patch --type bugfix --description 'Fix errors processing empty userRiskData.{risk,trust,general} values.'
@andrewkroh andrewkroh marked this pull request as ready for review April 1, 2024 22:23
@andrewkroh andrewkroh requested a review from a team as a code owner April 1, 2024 22:23
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube
Copy link

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a surprising behaviour.

This is even more surprising.

POST /_ingest/pipeline/_simulate
{
  "pipeline": {
    "description": "_description",
    "processors": [
      {
        "kv": {
          "field": "foo",
          "field_split": " ",
          "value_split": "(=|$)"
        }
      }
    ]
  },
  "docs": [
    {
      "_index": "index",
      "_id": "id",
      "_source": {
        "foo": "bar=one"
      }
    },
    {
      "_index": "index",
      "_id": "id",
      "_source": {
        "foo": "rab"
      }
    },
    {
      "_index": "index",
      "_id": "id",
      "_source": {
        "foo": ""
      }
    }
  ]
}

@andrewkroh
Copy link
Member Author

This is even more surprising.

Agree. The behavior does not seem consistent.

@andrewkroh andrewkroh merged commit 2b39b37 into elastic:main Apr 2, 2024
@elasticmachine
Copy link

Package akamai - 2.23.1 containing this change is available at https://epr.elastic.co/search?package=akamai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:akamai Akamai (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants