[akamai.siem] don't fail on headers without values #9486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the kv processor not fail when it encounters an http header without a value (e.g. `jsessionid:\r\n`). In the value_split, this uses a regex to make the space after the colon optional. Closes #9484
[git-generate] cd akamai elastic-package changelog add --link #9486 --next patch --type bugfix --description 'Handle HTTP headers without values.'
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
reviewed
Apr 2, 2024
packages/akamai/data_stream/siem/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Dan Kortschak <[email protected]>
andrewkroh
commented
Apr 2, 2024
packages/akamai/data_stream/siem/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
100.0% Coverage on New Code
0.0% Duplication on New Code
efd6
approved these changes
Apr 3, 2024
|
Package akamai - 2.23.2 containing this change is available at https://epr.elastic.co/search?package=akamai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Make the kv processor not fail when it encounters an http header without a value (e.g.
jsessionid:\r\n). In the value_split, this uses a regex to make the space after the colon optional.Closes #9484
Checklist
changelog.ymlfile.