fixes sorting in profiler storage explorer #212583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses new 'nameTooltip' eui feature also updates sorting function of hostName field.
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
## Summary fixes elastic#197448 replaces `LabelWithHint` with new built-in `nameTooltip` prop Also updated sorting function for hostName column, as the default sorting doesn't take into account `host.id` when `host.name` is empty. https://github.com/user-attachments/assets/4e3632bf-61d0-4045-babd-2917fa7a204a ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
cauemarcondes
pushed a commit
to cauemarcondes/kibana
that referenced
this pull request
May 2, 2025
## Summary fixes elastic#197448 replaces `LabelWithHint` with new built-in `nameTooltip` prop Also updated sorting function for hostName column, as the default sorting doesn't take into account `host.id` when `host.name` is empty. https://github.com/user-attachments/assets/4e3632bf-61d0-4045-babd-2917fa7a204a ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6ce38c3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
cauemarcondes
added a commit
that referenced
this pull request
May 2, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [fixes sorting in profiler storage explorer (#212583)](#212583) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bryce Buchanan","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-02-27T15:53:44Z","message":"fixes sorting in profiler storage explorer (#212583)\n\n## Summary\nfixes #197448\nreplaces `LabelWithHint` with new built-in `nameTooltip` prop\nAlso updated sorting function for hostName column, as the default\nsorting doesn't take into account `host.id` when `host.name` is empty.\n\n\nhttps://github.com/user-attachments/assets/4e3632bf-61d0-4045-babd-2917fa7a204a\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6ce38c3c1b70124a2cded7b6c2ac7ef8aebb8435","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:skip","Team:obs-ux-infra_services","v9.1.0"],"title":"fixes sorting in profiler storage explorer","number":212583,"url":"https://github.com/elastic/kibana/pull/212583","mergeCommit":{"message":"fixes sorting in profiler storage explorer (#212583)\n\n## Summary\nfixes #197448\nreplaces `LabelWithHint` with new built-in `nameTooltip` prop\nAlso updated sorting function for hostName column, as the default\nsorting doesn't take into account `host.id` when `host.name` is empty.\n\n\nhttps://github.com/user-attachments/assets/4e3632bf-61d0-4045-babd-2917fa7a204a\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6ce38c3c1b70124a2cded7b6c2ac7ef8aebb8435"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/212583","number":212583,"mergeCommit":{"message":"fixes sorting in profiler storage explorer (#212583)\n\n## Summary\nfixes #197448\nreplaces `LabelWithHint` with new built-in `nameTooltip` prop\nAlso updated sorting function for hostName column, as the default\nsorting doesn't take into account `host.id` when `host.name` is empty.\n\n\nhttps://github.com/user-attachments/assets/4e3632bf-61d0-4045-babd-2917fa7a204a\n\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6ce38c3c1b70124a2cded7b6c2ac7ef8aebb8435"}}]}] BACKPORT--> Co-authored-by: Bryce Buchanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #197448
replaces
LabelWithHintwith new built-innameTooltippropAlso updated sorting function for hostName column, as the default sorting doesn't take into account
host.idwhenhost.nameis empty.Untitled.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines