[Synthetics] Show inspect configuration button always !! #213619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
cesco-f
approved these changes
Mar 10, 2025
Contributor
cesco-f
left a comment
There was a problem hiding this comment.
LGTM!
The only thing I noticed, not related to changes in your PR, is that when you close the Configuration flyout the Inspect configuration button tooltip is shown.
Not sure if this is the expected behaviour.
Contributor
|
Starting backport for target branches: 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
) ## Summary Just like SLO elastic#210734 Show inspect configuration button always, there is no point hiding it, it adds value while debugging. Also fixed the id being auto generated even for monitor being edited !! <img width="1724" alt="image" src="https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd" /> Changed default format to YAML and added a switch to show as JSON <img width="1728" alt="image" src="https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af" /> ### Testing Inspect configuration continue to work as expected. (cherry picked from commit 4b05bbc)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 10, 2025
) ## Summary Just like SLO elastic#210734 Show inspect configuration button always, there is no point hiding it, it adds value while debugging. Also fixed the id being auto generated even for monitor being edited !! <img width="1724" alt="image" src="https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd" /> Changed default format to YAML and added a switch to show as JSON <img width="1728" alt="image" src="https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af" /> ### Testing Inspect configuration continue to work as expected. (cherry picked from commit 4b05bbc)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2025
…) (#213759) # Backport This will backport the following commits from `main` to `9.0`: - [[Synthetics] Show inspect configuration button always !! (#213619)](#213619) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-10T14:53:28Z","message":"[Synthetics] Show inspect configuration button always !! (#213619)\n\n## Summary\n\nJust like SLO https://github.com/elastic/kibana/pull/210734\n\nShow inspect configuration button always, there is no point hiding it,\nit adds value while debugging.\n\nAlso fixed the id being auto generated even for monitor being edited !!\n\n<img width=\"1724\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd\"\n/>\n\n\nChanged default format to YAML and added a switch to show as JSON \n\n<img width=\"1728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af\"\n/>\n\n\n### Testing \n\nInspect configuration continue to work as expected.","sha":"4b05bbc955481487eec5babdd772f4f1a5c064db","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Synthetics] Show inspect configuration button always !!","number":213619,"url":"https://github.com/elastic/kibana/pull/213619","mergeCommit":{"message":"[Synthetics] Show inspect configuration button always !! (#213619)\n\n## Summary\n\nJust like SLO https://github.com/elastic/kibana/pull/210734\n\nShow inspect configuration button always, there is no point hiding it,\nit adds value while debugging.\n\nAlso fixed the id being auto generated even for monitor being edited !!\n\n<img width=\"1724\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd\"\n/>\n\n\nChanged default format to YAML and added a switch to show as JSON \n\n<img width=\"1728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af\"\n/>\n\n\n### Testing \n\nInspect configuration continue to work as expected.","sha":"4b05bbc955481487eec5babdd772f4f1a5c064db"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213619","number":213619,"mergeCommit":{"message":"[Synthetics] Show inspect configuration button always !! (#213619)\n\n## Summary\n\nJust like SLO https://github.com/elastic/kibana/pull/210734\n\nShow inspect configuration button always, there is no point hiding it,\nit adds value while debugging.\n\nAlso fixed the id being auto generated even for monitor being edited !!\n\n<img width=\"1724\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd\"\n/>\n\n\nChanged default format to YAML and added a switch to show as JSON \n\n<img width=\"1728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af\"\n/>\n\n\n### Testing \n\nInspect configuration continue to work as expected.","sha":"4b05bbc955481487eec5babdd772f4f1a5c064db"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Mar 10, 2025
…) (#213758) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Show inspect configuration button always !! (#213619)](#213619) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-10T14:53:28Z","message":"[Synthetics] Show inspect configuration button always !! (#213619)\n\n## Summary\n\nJust like SLO https://github.com/elastic/kibana/pull/210734\n\nShow inspect configuration button always, there is no point hiding it,\nit adds value while debugging.\n\nAlso fixed the id being auto generated even for monitor being edited !!\n\n<img width=\"1724\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd\"\n/>\n\n\nChanged default format to YAML and added a switch to show as JSON \n\n<img width=\"1728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af\"\n/>\n\n\n### Testing \n\nInspect configuration continue to work as expected.","sha":"4b05bbc955481487eec5babdd772f4f1a5c064db","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Synthetics] Show inspect configuration button always !!","number":213619,"url":"https://github.com/elastic/kibana/pull/213619","mergeCommit":{"message":"[Synthetics] Show inspect configuration button always !! (#213619)\n\n## Summary\n\nJust like SLO https://github.com/elastic/kibana/pull/210734\n\nShow inspect configuration button always, there is no point hiding it,\nit adds value while debugging.\n\nAlso fixed the id being auto generated even for monitor being edited !!\n\n<img width=\"1724\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd\"\n/>\n\n\nChanged default format to YAML and added a switch to show as JSON \n\n<img width=\"1728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af\"\n/>\n\n\n### Testing \n\nInspect configuration continue to work as expected.","sha":"4b05bbc955481487eec5babdd772f4f1a5c064db"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/213619","number":213619,"mergeCommit":{"message":"[Synthetics] Show inspect configuration button always !! (#213619)\n\n## Summary\n\nJust like SLO https://github.com/elastic/kibana/pull/210734\n\nShow inspect configuration button always, there is no point hiding it,\nit adds value while debugging.\n\nAlso fixed the id being auto generated even for monitor being edited !!\n\n<img width=\"1724\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd\"\n/>\n\n\nChanged default format to YAML and added a switch to show as JSON \n\n<img width=\"1728\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af\"\n/>\n\n\n### Testing \n\nInspect configuration continue to work as expected.","sha":"4b05bbc955481487eec5babdd772f4f1a5c064db"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Shahzad <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
) ## Summary Just like SLO elastic#210734 Show inspect configuration button always, there is no point hiding it, it adds value while debugging. Also fixed the id being auto generated even for monitor being edited !! <img width="1724" alt="image" src="https://github.com/user-attachments/assets/31bd7a68-08d5-4a1e-a5c3-d52f58e793fd" /> Changed default format to YAML and added a switch to show as JSON <img width="1728" alt="image" src="https://github.com/user-attachments/assets/7b4ef88e-5f9e-4ec2-a9da-9606c743f3af" /> ### Testing Inspect configuration continue to work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just like SLO #210734
Show inspect configuration button always, there is no point hiding it, it adds value while debugging.
Also fixed the id being auto generated even for monitor being edited !!
Changed default format to YAML and added a switch to show as JSON
Testing
Inspect configuration continue to work as expected.