[SLO] add ability to select all services for apm slos #214653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Contributor
|
I think we can let the user choose a specific value for the other fields, even when the service.name is ALL. I've tested quickly on the branch: |
kdelemme
requested changes
Mar 14, 2025
Contributor
kdelemme
left a comment
There was a problem hiding this comment.
There are a few things we can change:
- remove allowAllOption from component since we always allow it. This should simplify a bit the options generation.
- remove the isDisabled check since we don't rely on a ServiceName anymore.
- Update the hook to include the serviceName query parameter if and only if the serviceName is not ALL_VALUE
x-pack/solutions/observability/plugins/slo/public/hooks/use_fetch_apm_suggestions.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
|
Contributor
Author
|
@elasticmachine merge upstream |
kdelemme
reviewed
Mar 17, 2025
Contributor
kdelemme
left a comment
There was a problem hiding this comment.
thanks for making the changes. One last neat. And have you tried editing an SLO created with an APM indicator (some with All, some with specific values?)? Are the fields pre-filled correctly?
x-pack/solutions/observability/plugins/slo/public/hooks/use_fetch_apm_suggestions.ts
Outdated
Show resolved
Hide resolved
…tch_apm_suggestions.ts Co-authored-by: Kevin Delemme <[email protected]>
kdelemme
reviewed
Mar 18, 2025
x-pack/solutions/observability/plugins/slo/public/hooks/use_fetch_apm_suggestions.ts
Outdated
Show resolved
Hide resolved
kdelemme
approved these changes
Mar 18, 2025
Contributor
💔 Build Failed
Failed CI StepsTest Failures
History
|
clintandrewhall
pushed a commit
to clintandrewhall/kibana
that referenced
this pull request
Mar 20, 2025
## Summary Resolves elastic#212981  ## Release Notes Adds the ability to create an APM availability or latency SLO for all services --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kevin Delemme <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Mar 22, 2025
## Summary Resolves elastic#212981  ## Release Notes Adds the ability to create an APM availability or latency SLO for all services --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kevin Delemme <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Mar 24, 2025
## Summary Resolves elastic#212981  ## Release Notes Adds the ability to create an APM availability or latency SLO for all services --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kevin Delemme <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Mar 31, 2025
## Summary Resolves elastic#212981  ## Release Notes Adds the ability to create an APM availability or latency SLO for all services --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kevin Delemme <[email protected]>
baileycash-elastic
added a commit
to baileycash-elastic/kibana
that referenced
this pull request
May 6, 2025
## Summary Resolves elastic#212981  ## Release Notes Adds the ability to create an APM availability or latency SLO for all services --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kevin Delemme <[email protected]> (cherry picked from commit 0a10127)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
baileycash-elastic
added a commit
that referenced
this pull request
May 7, 2025
#220268) # Backport This will backport the following commits from `main` to `8.19`: - [[SLO] add ability to select all services for apm slos (#214653)](#214653) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Bailey Cash","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-18T19:23:19Z","message":"[SLO] add ability to select all services for apm slos (#214653)\n\n## Summary\n\nResolves #212981\n\n\n\n## Release Notes\n\nAdds the ability to create an APM availability or latency SLO for all\nservices\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>\nCo-authored-by: Kevin Delemme <[email protected]>","sha":"0a10127efccc07846efdf6fe1e63bdbd75d62f4f","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport:skip","Team:obs-ux-management","v9.1.0"],"title":"[SLO] add ability to select all services for apm slos","number":214653,"url":"https://github.com/elastic/kibana/pull/214653","mergeCommit":{"message":"[SLO] add ability to select all services for apm slos (#214653)\n\n## Summary\n\nResolves #212981\n\n\n\n## Release Notes\n\nAdds the ability to create an APM availability or latency SLO for all\nservices\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>\nCo-authored-by: Kevin Delemme <[email protected]>","sha":"0a10127efccc07846efdf6fe1e63bdbd75d62f4f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/214653","number":214653,"mergeCommit":{"message":"[SLO] add ability to select all services for apm slos (#214653)\n\n## Summary\n\nResolves #212981\n\n\n\n## Release Notes\n\nAdds the ability to create an APM availability or latency SLO for all\nservices\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>\nCo-authored-by: Kevin Delemme <[email protected]>","sha":"0a10127efccc07846efdf6fe1e63bdbd75d62f4f"}}]}] BACKPORT--> --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Kevin Delemme <[email protected]> Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #212981
Release Notes
Adds the ability to create an APM availability or latency SLO for all services