Skip to content

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Mar 24, 2025

Summary

Copying most of #214017 !!

Fixes #214372

Implementation

We are now using response ops alerts table with custom score querying based on tags/groups matches and Jaccard similarity on documents !!

image

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 25, 2025
@shahzad31 shahzad31 marked this pull request as ready for review March 25, 2025 17:29
@shahzad31 shahzad31 requested review from a team as code owners March 25, 2025 17:29
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Mar 25, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done ! I'll let you decide if the Callout is needed or not.

image

Comment on lines 57 to 73
<EuiFlexGroup direction="column" gutterSize="m">
<EuiSpacer size="s" />
<EuiCallOut
size="s"
title={i18n.translate(
'xpack.observability.relatedAlertsView.euiCallOut.relatedAlertsHeuristicsLabel',
{ defaultMessage: 'Related alerts heuristics' }
)}
iconType="search"
>
<p>
{i18n.translate('xpack.observability.relatedAlertsView.p.weAreFetchingAlertsLabel', {
defaultMessage:
"We are fetching relevant alerts to the current alert based on some heuristics. Soon you'll be able to tweaks the weights applied to these heuristics",
})}
</p>
</EuiCallOut>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we keep this?

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obs changes LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 1292 1295 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerting-types 249 250 +1
observability 748 749 +1
total +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 1.3MB 1.3MB +208.0B
embeddableAlertsTable 796.4KB 796.6KB +204.0B
ml 5.3MB 5.3MB +204.0B
observability 1.3MB 1.3MB -1.4KB
securitySolution 9.0MB 9.0MB +256.0B
triggersActionsUi 1.4MB 1.4MB +205.0B
total -375.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 94.8KB 94.5KB -232.0B
Unknown metric groups

API count

id before after diff
@kbn/alerting-types 253 254 +1

async chunk count

id before after diff
observability 28 25 -3

ESLint disabled line counts

id before after diff
observability 49 46 -3

Total ESLint disabled count

id before after diff
observability 50 47 -3

History

@dominiqueclarke dominiqueclarke merged commit 760106e into elastic:main Apr 14, 2025
9 checks passed
@dominiqueclarke dominiqueclarke deleted the related-alerts branch April 14, 2025 15:35
@dominiqueclarke dominiqueclarke added backport:version Backport to applied version labels v8.19.0 and removed backport:skip This PR does not require backporting labels Apr 14, 2025
@kibanamachine
Copy link
Contributor

@kibanamachine
Copy link
Contributor

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 215673

Questions ?

Please refer to the Backport tool documentation

1 similar comment
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 215673

Questions ?

Please refer to the Backport tool documentation

@dominiqueclarke
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 15, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

1 similar comment
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

shahzad31 added a commit that referenced this pull request Apr 22, 2025
…218664)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Observability] Related alerts based on scoring !!
(#215673)](#215673)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-14T15:35:40Z","message":"[Observability]
Related alerts based on scoring !! (#215673)\n\n## Summary\n\nCopying
most of #214017 !!\n\nFixes
https://github.com/elastic/kibana/issues/214372\n\n###
Implementation\nWe are now using response ops alerts table with custom
score querying\nbased on tags/groups matches and Jaccard similarity on
documents !!\n\n\n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b3a69280-c05d-4100-be6a-2c8dadcc051d\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>\nCo-authored-by:
Dominique Clarke <[email protected]>\nCo-authored-by: Kevin
Delemme
<[email protected]>","sha":"760106eb8611a934d10157fb021979637d49dae4","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Observability]
Related alerts based on scoring
!!","number":215673,"url":"https://github.com/elastic/kibana/pull/215673","mergeCommit":{"message":"[Observability]
Related alerts based on scoring !! (#215673)\n\n## Summary\n\nCopying
most of #214017 !!\n\nFixes
https://github.com/elastic/kibana/issues/214372\n\n###
Implementation\nWe are now using response ops alerts table with custom
score querying\nbased on tags/groups matches and Jaccard similarity on
documents !!\n\n\n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b3a69280-c05d-4100-be6a-2c8dadcc051d\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>\nCo-authored-by:
Dominique Clarke <[email protected]>\nCo-authored-by: Kevin
Delemme
<[email protected]>","sha":"760106eb8611a934d10157fb021979637d49dae4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215673","number":215673,"mergeCommit":{"message":"[Observability]
Related alerts based on scoring !! (#215673)\n\n## Summary\n\nCopying
most of #214017 !!\n\nFixes
https://github.com/elastic/kibana/issues/214372\n\n###
Implementation\nWe are now using response ops alerts table with custom
score querying\nbased on tags/groups matches and Jaccard similarity on
documents !!\n\n\n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/b3a69280-c05d-4100-be6a-2c8dadcc051d\"\n/>\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>\nCo-authored-by:
Dominique Clarke <[email protected]>\nCo-authored-by: Kevin
Delemme
<[email protected]>","sha":"760106eb8611a934d10157fb021979637d49dae4"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Shahzad <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 22, 2025
@jasonrhodes jasonrhodes added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:feature Makes this part of the condensed release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Incident Management] [Related alerts] Replace existing AlertsTable with scoring query and simpler table