Skip to content

[Obs AI Assistant] Archiving conversations #216012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viduni94 merged 21 commits into from
Apr 8, 2025
Merged

[Obs AI Assistant] Archiving conversations #216012

viduni94 merged 21 commits into from
Apr 8, 2025

Conversation

@viduni94
Copy link
Contributor

@viduni94 viduni94 commented Mar 26, 2025 •
edited by kibanamachine
Loading

Closes #209386

Summary

  1. The option to archive conversations are enabled via the conversation contextual menu.
  2. Archived conversations can be viewed under the "Archived" section of the conversation list.
  3. Only the owner of the conversation can archive and unarchive.
  4. Once archived, the conversation cannot be continued until unarchived.
  5. If the archived conversation is shared, other users (who are not the owner) can duplicate the conversation, if they wish to continue the conversation.
  6. The archived section of the conversation list is collapsed by default.
  7. Updating the conversation such as title updates, regenerating, providing chat feedback are disabled for archived conversations

Checklist

@viduni94 viduni94 added release_note:feature Makes this part of the condensed release notes Team:Obs AI Assistant Observability AI Assistant backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Mar 26, 2025
@viduni94 viduni94 self-assigned this Mar 26, 2025
@viduni94 viduni94 marked this pull request as ready for review March 27, 2025 14:08
@viduni94 viduni94 requested review from a team as code owners March 27, 2025 14:08
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 27, 2025

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Mar 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@elastic elastic deleted a comment from kibanamachine Mar 28, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 28, 2025

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#8118

[✅] x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts: 25/25 tests passed.
[✅] x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts: 25/25 tests passed.

see run history

arturoliduena
arturoliduena reviewed Apr 3, 2025
View reviewed changes
@viduni94 viduni94 requested a review from arturoliduena April 3, 2025 14:14
sorenlouv
sorenlouv approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just small nits

sorenlouv
sorenlouv reviewed Apr 4, 2025
View reviewed changes
x-pack/platform/packages/shared/kbn-ai-assistant/src/hooks/use_conversation_context_menu.ts

try {
const archivedConversation = await service.callApi(
`PATCH /internal/observability_ai_assistant/conversation/{conversationId}`,
Copy link
Member

@sorenlouv sorenlouv Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While PATCH is semantically the correct verb for partial updates I would stick to PUT for the majority of use cases. It's just dead simple and guaranteed to work in any environment.

If you want do avoid sending the full conversation it's also possible to add separate APIs like

POST /internal/observability_ai_assistant/conversation/{conversationId}/_archive
POST /internal/observability_ai_assistant/conversation/{conversationId}/_unarchive

(same goes for the public property)

That being said, don't change this. It's fine as it is. Just thinking out loud (and also so I can point to this if we ever get an SDH with somebody complaining that their old school proxy doesn't support PATCH requests :D )

Copy link
Contributor Author

@viduni94 viduni94 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sorenlouv

@viduni94 viduni94 removed the request for review from arturoliduena April 7, 2025 16:26
@elasticmachine
Copy link
Contributor

elasticmachine commented Apr 7, 2025 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: c947b09
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-216012-c947b09217a3

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #11 / AssetDocumentTab should select table tab when path tab is table

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ai-assistant 102 105 +3
observabilityAIAssistant 387 389 +2
total +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityAIAssistantApp 265.0KB 269.7KB +4.7KB
searchAssistant 158.9KB 163.6KB +4.7KB
total +9.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistant 38.2KB 38.3KB +105.0B
Unknown metric groups

API count

id before after diff
@kbn/ai-assistant 102 105 +3
observabilityAIAssistant 389 391 +2
total +5

History

cc @viduni94

@viduni94 viduni94 merged commit 3aa036d into elastic:main Apr 8, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 8, 2025

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14336477283

@kibanamachine
Copy link
Contributor

kibanamachine commented Apr 8, 2025

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 216012

Questions ?

Please refer to the Backport tool documentation

@viduni94 viduni94 mentioned this pull request Apr 8, 2025
Merged
@viduni94
Copy link
Contributor Author

viduni94 commented Apr 8, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

viduni94 added a commit to viduni94/kibana that referenced this pull request Apr 8, 2025
@viduni94
[Obs AI Assistant] Archiving conversations (elastic#216012)
b62a63d 
Closes elastic#209386

## Summary

1. The option to archive conversations are enabled via the conversation
contextual menu.
2. Archived conversations can be viewed under the "Archived" section of
the conversation list.
3. Only the owner of the conversation can archive and unarchive.
4. Once archived, the conversation cannot be continued until unarchived.
5. If the archived conversation is shared, other users (who are not the
owner) can duplicate the conversation, if they wish to continue the
conversation.
6. The archived section of the conversation list is collapsed by
default.
7. Updating the conversation such as title updates, regenerating,
providing chat feedback are disabled for archived conversations

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 3aa036d)

# Conflicts:
#	x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_body.tsx
viduni94 added a commit that referenced this pull request Apr 8, 2025
@viduni94
[8.x] [Obs AI Assistant] Archiving conversations (#216012) (#217550)
1e86f60 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Archiving conversations
(#216012)](#216012)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Viduni
Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-08T14:42:20Z","message":"[Obs
AI Assistant] Archiving conversations (#216012)\n\nCloses
https://github.com/elastic/kibana/issues/209386\n\n## Summary\n\n1. The
option to archive conversations are enabled via the
conversation\ncontextual menu.\n2. Archived conversations can be viewed
under the \"Archived\" section of\nthe conversation list.\n3. Only the
owner of the conversation can archive and unarchive.\n4. Once archived,
the conversation cannot be continued until unarchived.\n5. If the
archived conversation is shared, other users (who are not the\nowner)
can duplicate the conversation, if they wish to continue
the\nconversation.\n6. The archived section of the conversation list is
collapsed by\ndefault.\n7. Updating the conversation such as title
updates, regenerating,\nproviding chat feedback are disabled for
archived conversations\n\n### Checklist\n\n- [x] Any text added follows
[EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"3aa036d5156b3833307d0805f8b564f998b35d0c","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","Team:Obs
AI
Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"[Obs
AI Assistant] Archiving
conversations","number":216012,"url":"https://github.com/elastic/kibana/pull/216012","mergeCommit":{"message":"[Obs
AI Assistant] Archiving conversations (#216012)\n\nCloses
https://github.com/elastic/kibana/issues/209386\n\n## Summary\n\n1. The
option to archive conversations are enabled via the
conversation\ncontextual menu.\n2. Archived conversations can be viewed
under the \"Archived\" section of\nthe conversation list.\n3. Only the
owner of the conversation can archive and unarchive.\n4. Once archived,
the conversation cannot be continued until unarchived.\n5. If the
archived conversation is shared, other users (who are not the\nowner)
can duplicate the conversation, if they wish to continue
the\nconversation.\n6. The archived section of the conversation list is
collapsed by\ndefault.\n7. Updating the conversation such as title
updates, regenerating,\nproviding chat feedback are disabled for
archived conversations\n\n### Checklist\n\n- [x] Any text added follows
[EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"3aa036d5156b3833307d0805f8b564f998b35d0c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216012","number":216012,"mergeCommit":{"message":"[Obs
AI Assistant] Archiving conversations (#216012)\n\nCloses
https://github.com/elastic/kibana/issues/209386\n\n## Summary\n\n1. The
option to archive conversations are enabled via the
conversation\ncontextual menu.\n2. Archived conversations can be viewed
under the \"Archived\" section of\nthe conversation list.\n3. Only the
owner of the conversation can archive and unarchive.\n4. Once archived,
the conversation cannot be continued until unarchived.\n5. If the
archived conversation is shared, other users (who are not the\nowner)
can duplicate the conversation, if they wish to continue
the\nconversation.\n6. The archived section of the conversation list is
collapsed by\ndefault.\n7. Updating the conversation such as title
updates, regenerating,\nproviding chat feedback are disabled for
archived conversations\n\n### Checklist\n\n- [x] Any text added follows
[EUI's
writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\nsentence case text and includes
[i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n-
[x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common scenarios\n- [x] [Flaky
Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\nused on any tests changed\n- [x] The PR description includes the
appropriate Release Notes section,\nand the correct `release_note:*`
label is applied per
the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"3aa036d5156b3833307d0805f8b564f998b35d0c"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sorenlouv sorenlouv sorenlouv approved these changes

@arturoliduena arturoliduena arturoliduena left review comments

Assignees

@viduni94 viduni94

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:feature Makes this part of the condensed release notes Team:Obs AI Assistant Observability AI Assistant v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Obs AI Assistant] Archiving conversations

5 participants

@viduni94 @elasticmachine @kibanamachine @sorenlouv @arturoliduena