Skip to content

Conversation

@rmyz
Copy link
Contributor

@rmyz rmyz commented Apr 3, 2025

Summary

Fixes #216790

This PR fixes the z-indexes changed in the emotion migration PR, using the same value (2000) as before.
Also it uses EuiButtonIcon instead of EuiButtonEmpty and aligns its content.

Before

image

After

image

@rmyz rmyz added release_note:fix apm backport:version Backport to applied version labels v8.19.0 labels Apr 3, 2025
@rmyz rmyz self-assigned this Apr 3, 2025
@rmyz rmyz requested a review from a team as a code owner April 3, 2025 08:40
@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Apr 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM 💯

@rmyz rmyz merged commit cc4ed13 into elastic:main Apr 3, 2025
20 checks passed
@kibanamachine
Copy link
Contributor

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 216972

Questions ?

Please refer to the Backport tool documentation

@rmyz rmyz deleted the 216790-apm-fix-foldable-button branch April 3, 2025 13:50
@rmyz
Copy link
Contributor Author

rmyz commented Apr 3, 2025

No need to backport this to 8.x since the error was introduced in this PR and that didn't get merged into 8.x

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 4, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216972 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 216972 locally

@rmyz rmyz added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels v8.19.0 labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm backport:skip This PR does not require backporting release_note:fix Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Unclickable Fold/Unfold button in Trace Waterfall explorer

4 participants