Adjust example to ndjson format #221617
Merged
Adjust example to ndjson format #221617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
reviewed
May 27, 2025
...ility_ai_assistant_management/public/routes/components/knowledge_base_bulk_import_flyout.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
sorenlouv
approved these changes
May 27, 2025
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
## Summary Closes elastic#221370 Modify the text of the example in the bulk import knowledge base entry flyout. The example had a trailing comma after the last field, making it invalid json. I used JSON.stringify in order to avoid typos, and added multiple objects to show the actual ndjson format. I also put the objects all in one line since .ndjson objects are generally represented without newlines. ## BEFORE <img width="1505" alt="Screenshot 2025-05-27 at 14 48 32" src="https://github.com/user-attachments/assets/b4464e07-95a2-4b84-b0df-ccc4a896003a" /> ## AFTER <img width="1504" alt="Screenshot 2025-05-27 at 17 15 19" src="https://github.com/user-attachments/assets/ff079956-25df-4b3b-8b16-f27ba4dd2300" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
## Summary Closes elastic#221370 Modify the text of the example in the bulk import knowledge base entry flyout. The example had a trailing comma after the last field, making it invalid json. I used JSON.stringify in order to avoid typos, and added multiple objects to show the actual ndjson format. I also put the objects all in one line since .ndjson objects are generally represented without newlines. ## BEFORE <img width="1505" alt="Screenshot 2025-05-27 at 14 48 32" src="https://github.com/user-attachments/assets/b4464e07-95a2-4b84-b0df-ccc4a896003a" /> ## AFTER <img width="1504" alt="Screenshot 2025-05-27 at 17 15 19" src="https://github.com/user-attachments/assets/ff079956-25df-4b3b-8b16-f27ba4dd2300" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
|
Starting backport for target branches: 8.19 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 9, 2025
## Summary Closes elastic#221370 Modify the text of the example in the bulk import knowledge base entry flyout. The example had a trailing comma after the last field, making it invalid json. I used JSON.stringify in order to avoid typos, and added multiple objects to show the actual ndjson format. I also put the objects all in one line since .ndjson objects are generally represented without newlines. ## BEFORE <img width="1505" alt="Screenshot 2025-05-27 at 14 48 32" src="https://github.com/user-attachments/assets/b4464e07-95a2-4b84-b0df-ccc4a896003a" /> ## AFTER <img width="1504" alt="Screenshot 2025-05-27 at 17 15 19" src="https://github.com/user-attachments/assets/ff079956-25df-4b3b-8b16-f27ba4dd2300" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 1e15974)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 9, 2025
## Summary Closes elastic#221370 Modify the text of the example in the bulk import knowledge base entry flyout. The example had a trailing comma after the last field, making it invalid json. I used JSON.stringify in order to avoid typos, and added multiple objects to show the actual ndjson format. I also put the objects all in one line since .ndjson objects are generally represented without newlines. ## BEFORE <img width="1505" alt="Screenshot 2025-05-27 at 14 48 32" src="https://github.com/user-attachments/assets/b4464e07-95a2-4b84-b0df-ccc4a896003a" /> ## AFTER <img width="1504" alt="Screenshot 2025-05-27 at 17 15 19" src="https://github.com/user-attachments/assets/ff079956-25df-4b3b-8b16-f27ba4dd2300" /> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 1e15974)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 similar comment
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 9, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Adjust bulk import example to ndjson format (#221617)](#221617) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Eleonora","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-05-28T10:19:11Z","message":"Adjust bulk import example to ndjson format (#221617)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/221370\nModify the text of the example in the bulk import knowledge base entry\nflyout.\nThe example had a trailing comma after the last field, making it invalid\njson.\n\nI used JSON.stringify in order to avoid typos, and added multiple\nobjects to show the actual ndjson format.\nI also put the objects all in one line since .ndjson objects are\ngenerally represented without newlines.\n\n## BEFORE\n<img width=\"1505\" alt=\"Screenshot 2025-05-27 at 14 48 32\"\nsrc=\"https://github.com/user-attachments/assets/b4464e07-95a2-4b84-b0df-ccc4a896003a\"\n/>\n\n## AFTER\n<img width=\"1504\" alt=\"Screenshot 2025-05-27 at 17 15 19\"\nsrc=\"https://github.com/user-attachments/assets/ff079956-25df-4b3b-8b16-f27ba4dd2300\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"1e159749d3377ea8a3f061454868b94f40eb493c","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v9.1.0","v8.19.0"],"title":"Adjust example to ndjson format","number":221617,"url":"https://github.com/elastic/kibana/pull/221617","mergeCommit":{"message":"Adjust bulk import example to ndjson format (#221617)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/221370\nModify the text of the example in the bulk import knowledge base entry\nflyout.\nThe example had a trailing comma after the last field, making it invalid\njson.\n\nI used JSON.stringify in order to avoid typos, and added multiple\nobjects to show the actual ndjson format.\nI also put the objects all in one line since .ndjson objects are\ngenerally represented without newlines.\n\n## BEFORE\n<img width=\"1505\" alt=\"Screenshot 2025-05-27 at 14 48 32\"\nsrc=\"https://github.com/user-attachments/assets/b4464e07-95a2-4b84-b0df-ccc4a896003a\"\n/>\n\n## AFTER\n<img width=\"1504\" alt=\"Screenshot 2025-05-27 at 17 15 19\"\nsrc=\"https://github.com/user-attachments/assets/ff079956-25df-4b3b-8b16-f27ba4dd2300\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"1e159749d3377ea8a3f061454868b94f40eb493c"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/221617","number":221617,"mergeCommit":{"message":"Adjust bulk import example to ndjson format (#221617)\n\n## Summary\n\nCloses https://github.com/elastic/kibana/issues/221370\nModify the text of the example in the bulk import knowledge base entry\nflyout.\nThe example had a trailing comma after the last field, making it invalid\njson.\n\nI used JSON.stringify in order to avoid typos, and added multiple\nobjects to show the actual ndjson format.\nI also put the objects all in one line since .ndjson objects are\ngenerally represented without newlines.\n\n## BEFORE\n<img width=\"1505\" alt=\"Screenshot 2025-05-27 at 14 48 32\"\nsrc=\"https://github.com/user-attachments/assets/b4464e07-95a2-4b84-b0df-ccc4a896003a\"\n/>\n\n## AFTER\n<img width=\"1504\" alt=\"Screenshot 2025-05-27 at 17 15 19\"\nsrc=\"https://github.com/user-attachments/assets/ff079956-25df-4b3b-8b16-f27ba4dd2300\"\n/>\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"1e159749d3377ea8a3f061454868b94f40eb493c"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Eleonora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #221370
Modify the text of the example in the bulk import knowledge base entry flyout.
The example had a trailing comma after the last field, making it invalid json.
I used JSON.stringify in order to avoid typos, and added multiple objects to show the actual ndjson format.
I also put the objects all in one line since .ndjson objects are generally represented without newlines.
BEFORE
AFTER
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines