Skip to content

[Synthetics] Maintenance windows !! #222174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahzad31 merged 23 commits into from
Jun 19, 2025
Merged

[Synthetics] Maintenance windows !! #222174

shahzad31 merged 23 commits into from
Jun 19, 2025

Conversation

@shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jun 2, 2025 •
edited by kibanamachine
Loading

Summary

fixes #211540

User will be able to choose maintenance window in the form

image

A callout will be displayed on the form
image

Task manager

When changes are made to maintenance windows, those are sync via task manager to private location monitors, public location monitors are automatically synced as well in already existing task.

Testing

Create a maintenance window in stack management UI, apply it to monitor, make sure, it never runs during maintenance window.

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jun 2, 2025
@shahzad31 shahzad31 force-pushed the maintenance-windows branch from 3653339 to 4b97d5c Compare June 2, 2025 13:01
@shahzad31 shahzad31 added ci:project-deploy-observability Create an Observability project release_note:feature Makes this part of the condensed release notes labels Jun 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added backport:version Backport to applied version labels v8.19.0 labels Jun 4, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 4, 2025

Project deployed, see credentials at: https://buildkite.com/elastic/kibana-deploy-project-from-pr/builds/475

@cesco-f cesco-f self-assigned this Jun 4, 2025
@shahzad31 shahzad31 marked this pull request as ready for review June 4, 2025 16:42
@shahzad31 shahzad31 requested review from a team as code owners June 4, 2025 16:42
@shahzad31 shahzad31 force-pushed the maintenance-windows branch from 0140e4d to 65e7a61 Compare June 4, 2025 17:06
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Jun 4, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 4, 2025

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

cesco-f
cesco-f reviewed Jun 6, 2025
View reviewed changes
@emilioalvap
Copy link
Contributor

emilioalvap commented Jun 8, 2025

/oblt-deploy

cesco-f
cesco-f approved these changes Jun 10, 2025
View reviewed changes
Copy link
Contributor

@cesco-f cesco-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have a couple of unresolved conversations but in general LGTM.

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner June 11, 2025 15:40
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/jest_integration -u…
a5aad5a 
… src/core/server/integration_tests/ci_checks'
Bamieh
Bamieh approved these changes Jun 12, 2025
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM (new saved object property for maintenance_windows keyword )

@jcger
Copy link
Contributor

jcger commented Jun 12, 2025

Please don't merge, I approved initially (that's why the merge button is enabled) but I removed that approval. response-ops still needs to review

@shahzad31
Copy link
Contributor Author

shahzad31 commented Jun 16, 2025

Please don't merge, I approved initially (that's why the merge button is enabled) but I removed that approval. response-ops still needs to review

@jcger do you have any feedback for the PR?

cnasikas
cnasikas approved these changes Jun 18, 2025
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed offline all of the implications with this approach, and the o11y team is aware of them. As we decided, we will move forward with the feature, and O11y will be responsible for any future work or migration needed regarding the upcoming MW enhancements. Thanks for your patience!

@elasticmachine
Copy link
Contributor

elasticmachine commented Jun 19, 2025 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 5d77f24
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-222174-5d77f245ab62

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1235 1247 +12

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/alerts-ui-shared 294 297 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 1.3MB 1.3MB +90.0B
synthetics 1.0MB 1.0MB +7.7KB
total +7.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/alerts-ui-shared 6 7 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 27.8KB 27.8KB +4.0B

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/saved-objects-service.html#_mappings

id before after diff
synthetics-monitor 33 34 +1
Unknown metric groups

API count

id before after diff
@kbn/alerts-ui-shared 311 314 +3

History

cc @cesco-f

@shahzad31 shahzad31 merged commit b991e82 into elastic:main Jun 19, 2025
10 checks passed
@shahzad31 shahzad31 deleted the maintenance-windows branch June 19, 2025 15:49
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 19, 2025

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15761808012

@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 19, 2025

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 222174

Questions ?

Please refer to the Backport tool documentation

@shahzad31 shahzad31 mentioned this pull request Jun 19, 2025
Merged
@shahzad31
Copy link
Contributor Author

shahzad31 commented Jun 19, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jun 19, 2025
@shahzad31
[Synthetics] Maintenance windows !! (elastic#222174)
b8aaf63 
## Summary

fixes elastic#211540

User will be able to choose maintenance window in the form

<img width="1723" alt="image"
src="https://github.com/user-attachments/assets/c4d75aff-687f-40d3-a614-160e99ce9ac2"
/>

A callout will be displayed on the form
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/124727bd-0bb6-4934-9406-a36c3584670a"
/>

### Task manager
When changes are made to maintenance windows, those are sync via task
manager to private location monitors, public location monitors are
automatically synced as well in already existing task.

### Testing

Create a maintenance window in stack management UI, apply it to monitor,
make sure, it never runs during maintenance window.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit b991e82)

# Conflicts:
#	x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/monitor_summary.tsx
#	x-pack/solutions/observability/plugins/synthetics/tsconfig.json
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/synthetics/sample_data/test_project_monitor_policy.ts
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 20, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Jun 20, 2025

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @cesco-f

shahzad31 added a commit that referenced this pull request Jun 23, 2025
@shahzad31
[8.19] [Synthetics] Maintenance windows !! (#222174) (#224617)
c191363 
# Backport

This will backport the following commits from `main` to `8.19`:
- [[Synthetics] Maintenance windows !!
(#222174)](#222174)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-19T15:49:29Z","message":"[Synthetics]
Maintenance windows !! (#222174)\n\n## Summary\n\nfixes
https://github.com/elastic/kibana/issues/211540\n\nUser will be able to
choose maintenance window in the form \n\n<img width=\"1723\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c4d75aff-687f-40d3-a614-160e99ce9ac2\"\n/>\n\nA
callout will be displayed on the form \n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/124727bd-0bb6-4934-9406-a36c3584670a\"\n/>\n\n\n###
Task manager \nWhen changes are made to maintenance windows, those are
sync via task\nmanager to private location monitors, public location
monitors are\nautomatically synced as well in already existing
task.\n\n\n### Testing\n\nCreate a maintenance window in stack
management UI, apply it to monitor,\nmake sure, it never runs during
maintenance window.\n\n---------\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"b991e82700c2eb28d03d1549b8215abb4b4fce1d","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:feature","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management"],"title":"[Synthetics]
Maintenance windows
!!","number":222174,"url":"https://github.com/elastic/kibana/pull/222174","mergeCommit":{"message":"[Synthetics]
Maintenance windows !! (#222174)\n\n## Summary\n\nfixes
https://github.com/elastic/kibana/issues/211540\n\nUser will be able to
choose maintenance window in the form \n\n<img width=\"1723\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c4d75aff-687f-40d3-a614-160e99ce9ac2\"\n/>\n\nA
callout will be displayed on the form \n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/124727bd-0bb6-4934-9406-a36c3584670a\"\n/>\n\n\n###
Task manager \nWhen changes are made to maintenance windows, those are
sync via task\nmanager to private location monitors, public location
monitors are\nautomatically synced as well in already existing
task.\n\n\n### Testing\n\nCreate a maintenance window in stack
management UI, apply it to monitor,\nmake sure, it never runs during
maintenance window.\n\n---------\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"b991e82700c2eb28d03d1549b8215abb4b4fce1d"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/222174","number":222174,"mergeCommit":{"message":"[Synthetics]
Maintenance windows !! (#222174)\n\n## Summary\n\nfixes
https://github.com/elastic/kibana/issues/211540\n\nUser will be able to
choose maintenance window in the form \n\n<img width=\"1723\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c4d75aff-687f-40d3-a614-160e99ce9ac2\"\n/>\n\nA
callout will be displayed on the form \n<img width=\"1728\"
alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/124727bd-0bb6-4934-9406-a36c3584670a\"\n/>\n\n\n###
Task manager \nWhen changes are made to maintenance windows, those are
sync via task\nmanager to private location monitors, public location
monitors are\nautomatically synced as well in already existing
task.\n\n\n### Testing\n\nCreate a maintenance window in stack
management UI, apply it to monitor,\nmake sure, it never runs during
maintenance window.\n\n---------\n\nCo-authored-by: kibanamachine
<[email protected]>","sha":"b991e82700c2eb28d03d1549b8215abb4b4fce1d"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 23, 2025
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request Jun 25, 2025
@shahzad31 @kibanamachine @akowalska622
[Synthetics] Maintenance windows !! (elastic#222174)
898872b 
## Summary

fixes elastic#211540

User will be able to choose maintenance window in the form 

<img width="1723" alt="image"
src="https://github.com/user-attachments/assets/c4d75aff-687f-40d3-a614-160e99ce9ac2"
/>

A callout will be displayed on the form 
<img width="1728" alt="image"
src="https://github.com/user-attachments/assets/124727bd-0bb6-4934-9406-a36c3584670a"
/>


### Task manager 
When changes are made to maintenance windows, those are sync via task
manager to private location monitors, public location monitors are
automatically synced as well in already existing task.


### Testing

Create a maintenance window in stack management UI, apply it to monitor,
make sure, it never runs during maintenance window.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Bamieh approved these changes

@cnasikas cnasikas cnasikas approved these changes

@cesco-f cesco-f cesco-f approved these changes

@jcger jcger Awaiting requested review from jcger

Assignees

@cesco-f cesco-f

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:feature Makes this part of the condensed release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.19.0 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Synthetics] Add maintenance windows support !!

8 participants

@shahzad31 @kibanamachine @elasticmachine @emilioalvap @jcger @Bamieh @cnasikas @cesco-f