-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[dashboard] migrate embeddable_data_grid test cases to discover functional test #223452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/ci |
Contributor
💚 Build Succeeded
Metrics [docs]
|
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jun 11, 2025
akowalska622
approved these changes
Jun 12, 2025
Contributor
|
Starting backport for target branches: 8.19 |
Contributor
💔 All backports failedManual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 12, 2025
…ional test (elastic#223452) `embeddable_data_grid` tests discover session embeddable functionality. This is owned by discover team and should not be part of dashboard test suite. This PR consolidates the test cases from embeddable_data_grid to _saved_search_embeddable.ts. (cherry picked from commit 05895de) # Conflicts: # src/platform/test/functional/apps/dashboard/group1/embeddable_data_grid.ts
nreese
added a commit
that referenced
this pull request
Jun 12, 2025
…r functional test (#223452) (#223559) # Backport This will backport the following commits from `main` to `8.19`: - [[dashboard] migrate embeddable_data_grid test cases to discover functional test (#223452)](#223452) <!--- Backport version: 10.0.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-12T13:08:38Z","message":"[dashboard] migrate embeddable_data_grid test cases to discover functional test (#223452)\n\n`embeddable_data_grid` tests discover session embeddable functionality.\nThis is owned by discover team and should not be part of dashboard test\nsuite. This PR consolidates the test cases from embeddable_data_grid to\n_saved_search_embeddable.ts.","sha":"05895de3ce2f9cd7b163e496158327ab41ce6867","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[dashboard] migrate embeddable_data_grid test cases to discover functional test","number":223452,"url":"https://github.com/elastic/kibana/pull/223452","mergeCommit":{"message":"[dashboard] migrate embeddable_data_grid test cases to discover functional test (#223452)\n\n`embeddable_data_grid` tests discover session embeddable functionality.\nThis is owned by discover team and should not be part of dashboard test\nsuite. This PR consolidates the test cases from embeddable_data_grid to\n_saved_search_embeddable.ts.","sha":"05895de3ce2f9cd7b163e496158327ab41ce6867"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223452","number":223452,"mergeCommit":{"message":"[dashboard] migrate embeddable_data_grid test cases to discover functional test (#223452)\n\n`embeddable_data_grid` tests discover session embeddable functionality.\nThis is owned by discover team and should not be part of dashboard test\nsuite. This PR consolidates the test cases from embeddable_data_grid to\n_saved_search_embeddable.ts.","sha":"05895de3ce2f9cd7b163e496158327ab41ce6867"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
…ional test (elastic#223452) `embeddable_data_grid` tests discover session embeddable functionality. This is owned by discover team and should not be part of dashboard test suite. This PR consolidates the test cases from embeddable_data_grid to _saved_search_embeddable.ts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
release_note:skip
Skip the PR/issue when compiling release notes
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas t//
v8.19.0
v9.1.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embeddable_data_gridtests discover session embeddable functionality. This is owned by discover team and should not be part of dashboard test suite. This PR consolidates the test cases from embeddable_data_grid to _saved_search_embeddable.ts.