Skip to content

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Jun 11, 2025

embeddable_data_grid tests discover session embeddable functionality. This is owned by discover team and should not be part of dashboard test suite. This PR consolidates the test cases from embeddable_data_grid to _saved_search_embeddable.ts.

@nreese
Copy link
Contributor Author

nreese commented Jun 11, 2025

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@nreese nreese marked this pull request as ready for review June 11, 2025 20:40
@nreese nreese requested review from a team as code owners June 11, 2025 20:40
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jun 11, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese merged commit 05895de into elastic:main Jun 12, 2025
22 checks passed
@kibanamachine
Copy link
Contributor

@nreese
Copy link
Contributor Author

nreese commented Jun 12, 2025

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nreese added a commit to nreese/kibana that referenced this pull request Jun 12, 2025
…ional test (elastic#223452)

`embeddable_data_grid` tests discover session embeddable functionality.
This is owned by discover team and should not be part of dashboard test
suite. This PR consolidates the test cases from embeddable_data_grid to
_saved_search_embeddable.ts.

(cherry picked from commit 05895de)

# Conflicts:
#	src/platform/test/functional/apps/dashboard/group1/embeddable_data_grid.ts
nreese added a commit that referenced this pull request Jun 12, 2025
…r functional test (#223452) (#223559)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[dashboard] migrate embeddable_data_grid test cases to discover
functional test
(#223452)](#223452)

<!--- Backport version: 10.0.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-12T13:08:38Z","message":"[dashboard]
migrate embeddable_data_grid test cases to discover functional test
(#223452)\n\n`embeddable_data_grid` tests discover session embeddable
functionality.\nThis is owned by discover team and should not be part of
dashboard test\nsuite. This PR consolidates the test cases from
embeddable_data_grid
to\n_saved_search_embeddable.ts.","sha":"05895de3ce2f9cd7b163e496158327ab41ce6867","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","backport:version","v9.1.0","v8.19.0"],"title":"[dashboard]
migrate embeddable_data_grid test cases to discover functional
test","number":223452,"url":"https://github.com/elastic/kibana/pull/223452","mergeCommit":{"message":"[dashboard]
migrate embeddable_data_grid test cases to discover functional test
(#223452)\n\n`embeddable_data_grid` tests discover session embeddable
functionality.\nThis is owned by discover team and should not be part of
dashboard test\nsuite. This PR consolidates the test cases from
embeddable_data_grid
to\n_saved_search_embeddable.ts.","sha":"05895de3ce2f9cd7b163e496158327ab41ce6867"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/223452","number":223452,"mergeCommit":{"message":"[dashboard]
migrate embeddable_data_grid test cases to discover functional test
(#223452)\n\n`embeddable_data_grid` tests discover session embeddable
functionality.\nThis is owned by discover team and should not be part of
dashboard test\nsuite. This PR consolidates the test cases from
embeddable_data_grid
to\n_saved_search_embeddable.ts.","sha":"05895de3ce2f9cd7b163e496158327ab41ce6867"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
…ional test (elastic#223452)

`embeddable_data_grid` tests discover session embeddable functionality.
This is owned by discover team and should not be part of dashboard test
suite. This PR consolidates the test cases from embeddable_data_grid to
_saved_search_embeddable.ts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.19.0 v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants