-
Notifications
You must be signed in to change notification settings - Fork 8.5k
fix(slo): use wildcard remote when useAllRemoteClusters is true #224478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
shahzad31
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
|
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0 |
…tic#224478) ### 🍒 Summary resolves elastic#224476 This PR changes how the summary indices are constructed when remote clusters is enabled. When `useAllRemoteCluster` is true, we simply use `*:summary-index` instead of listing each remote individually. We also removed the need to fetch the remote clusters info when we use `useAllRemoteCluster`. ### Release notes Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes. (cherry picked from commit aac0893)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
#224478) (#224531) # Backport This will backport the following commits from `main` to `8.19`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
…tic#224478) ### 🍒 Summary resolves elastic#224476 This PR changes how the summary indices are constructed when remote clusters is enabled. When `useAllRemoteCluster` is true, we simply use `*:summary-index` instead of listing each remote individually. We also removed the need to fetch the remote clusters info when we use `useAllRemoteCluster`. ### Release notes Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes. (cherry picked from commit aac0893) # Conflicts: # x-pack/solutions/observability/plugins/slo/common/summary_indices.test.ts # x-pack/solutions/observability/plugins/slo/common/summary_indices.ts # x-pack/solutions/observability/plugins/slo/server/services/slo_settings.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…tic#224478) ### 🍒 Summary resolves elastic#224476 This PR changes how the summary indices are constructed when remote clusters is enabled. When `useAllRemoteCluster` is true, we simply use `*:summary-index` instead of listing each remote individually. We also removed the need to fetch the remote clusters info when we use `useAllRemoteCluster`. ### Release notes Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes. (cherry picked from commit aac0893) # Conflicts: # x-pack/plugins/observability_solution/slo/common/summary_indices.test.ts # x-pack/plugins/observability_solution/slo/server/services/slo_settings.ts # x-pack/solutions/observability/plugins/slo/common/get_slo_summary_indices.ts
#224478) (#224581) # Backport This will backport the following commits from `main` to `8.17`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224531","number":224531,"state":"MERGED","mergeCommit":{"sha":"3590e18388bfe075c6158c8873e3c2f2be63a91f","message":"[8.19] fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478) (#224531)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [fix(slo): use wildcard remote when useAllRemoteClusters is true\n(#224478)](https://github.com/elastic/kibana/pull/224478)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Kevin Delemme <[email protected]>"}},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
…#224478) (#224577) # Backport This will backport the following commits from `main` to `9.0`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224531","number":224531,"state":"MERGED","mergeCommit":{"sha":"3590e18388bfe075c6158c8873e3c2f2be63a91f","message":"[8.19] fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478) (#224531)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [fix(slo): use wildcard remote when useAllRemoteClusters is true\n(#224478)](https://github.com/elastic/kibana/pull/224478)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Kevin Delemme <[email protected]>"}},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
#224478) (#224578) # Backport This will backport the following commits from `main` to `8.18`: - [fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)](#224478) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-19T09:04:15Z","message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.0.3","v8.18.3","v8.17.8"],"title":"fix(slo): use wildcard remote when useAllRemoteClusters is true","number":224478,"url":"https://github.com/elastic/kibana/pull/224478","mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224478","number":224478,"mergeCommit":{"message":"fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478)\n\n### 🍒 Summary\n\nresolves https://github.com/elastic/kibana/issues/224476\n\nThis PR changes how the summary indices are constructed when remote\nclusters is enabled.\n\nWhen `useAllRemoteCluster` is true, we simply use `*:summary-index`\ninstead of listing each remote individually.\nWe also removed the need to fetch the remote clusters info when we use\n`useAllRemoteCluster`.\n\n### Release notes\n\nFix SLO federated view bug when remote clusters and index name listed\nexceeded 4096 bytes.","sha":"aac08931d165e89b40832eac06fbb1ff19a1eecf"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/224531","number":224531,"state":"MERGED","mergeCommit":{"sha":"3590e18388bfe075c6158c8873e3c2f2be63a91f","message":"[8.19] fix(slo): use wildcard remote when useAllRemoteClusters is true (#224478) (#224531)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.19`:\n- [fix(slo): use wildcard remote when useAllRemoteClusters is true\n(#224478)](https://github.com/elastic/kibana/pull/224478)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Kevin Delemme <[email protected]>"}},{"branch":"9.0","label":"v9.0.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
|
This PR didn't get it on time into the latest BC for v8.17.8, v8.18.3 and v9.0.3. Updating the labels |
🍒 Summary
resolves #224476
This PR changes how the summary indices are constructed when remote clusters is enabled.
When
useAllRemoteClusteris true, we simply use*:summary-indexinstead of listing each remote individually.We also removed the need to fetch the remote clusters info when we use
useAllRemoteCluster.Release notes
Fix SLO federated view bug when remote clusters and index name listed exceeded 4096 bytes.