-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Add manual test for bulk import functionality #225497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manual test for bulk import functionality #225497
Conversation
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
...integration/deployment_agnostic/apis/observability/ai_assistant/utils/model_and_inference.ts
Outdated
Show resolved
Hide resolved
...integration/deployment_agnostic/apis/observability/ai_assistant/utils/model_and_inference.ts
Outdated
Show resolved
Hide resolved
...t_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_bulk_import.spec.ts
Outdated
Show resolved
Hide resolved
sorenlouv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't recall if this.tags(['skipServerless', 'skipStateful']); skips in all CI envs but I like the idea of running this locally. We might decide to skip it locally as well if it's too slow.
Looking at https://docs.elastic.dev/appex-qa/ftr/knowledge-base/ftr-users/skip-tests#:~:text=skipStateful,local%20and%20MKI). We could use skipCloud instead which I think will still run it on local, but I'm not sure about what would happen with the PR CI. @sorenlouv do you know who I could ask to make sure? |
Is it correct, that what you want is to skip it everywhere (CI, MKI, ECH) but run locally? I think @pheyos will know if that's possible (he'll probably ask why we want this uncommon behaviour :D) |
|
For tests that are not meant to run in any of our regular CI runs (local or cloud), we usually create a separate config file and list that under the Technically, you could also use a combination of skip tags to achieve the same, but I would only recommend this approach if you think the complete CI skip is a temporary thing and you plan to change these labels soon. |
I would indeed be curious to learn about your use case here. However, it sounds like you actually might run these tests locally and only skip cloud? FWIW, we have a number of test configs that are triggered only from separate pipeline or in certain workflows, so it's not a super rare thing to do. |
|
@pheyos I've updated the PR following your recommendations, thank you! |
...t_agnostic/apis/observability/ai_assistant/knowledge_base/knowledge_base_bulk_import.spec.ts
Outdated
Show resolved
Hide resolved
x-pack/test/api_integration/deployment_agnostic/apis/observability/ai_assistant/local/index.ts
Outdated
Show resolved
Hide resolved
...test/api_integration/deployment_agnostic/configs/serverless/oblt.ai_assistant_local.index.ts
Outdated
Show resolved
Hide resolved
...k/test/api_integration/deployment_agnostic/configs/stateful/oblt.ai_assistant_local.index.ts
Outdated
Show resolved
Hide resolved
..._integration/deployment_agnostic/configs/stateful/oblt.ai_assistant_local.stateful.config.ts
Outdated
Show resolved
Hide resolved
...test/api_integration/deployment_agnostic/configs/serverless/oblt.ai_assistant_local.index.ts
Outdated
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
pheyos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup for local-only / non-CI tests LGTM
## Summary Closes elastic#224911 Add test for bulk import functionality as a follow up to elastic#223501 This test should only be run locally, not on CI. For this reason, it has been added to a separate config for stateful and serverless, that is disabled in the ftr config files. In order to run this test locally, you can run: ``` node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/<stateful/serverless>/oblt.ai_assistant_local.<stateful/serverless>.config.ts ``` and then ``` node scripts/functional_test_runner --config=x-pack/test/api_integration/deployment_agnostic/configs/<stateful/serverless>/oblt.ai_assistant_local.<stateful/serverless>.config.ts ``` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Closes #224911
Add test for bulk import functionality as a follow up to #223501
This test should only be run locally, not on CI.
For this reason, it has been added to a separate config for stateful and serverless, that is disabled in the ftr config files.
In order to run this test locally, you can run:
and then
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines