Skip to content

Conversation

@cesco-f
Copy link
Contributor

@cesco-f cesco-f commented Aug 28, 2025

This PR is part of issue #230058.

The View in discover button has been added in the header of the alert details page for custom threshold rules.

Before:

Screen.Recording.2025-08-28.at.09.02.54.mov

After:

Screen.Recording.2025-08-28.at.09.01.46.mov

@cesco-f cesco-f requested a review from a team as a code owner August 28, 2025 07:07
@cesco-f cesco-f added release_note:enhancement backport:skip This PR does not require backporting labels Aug 28, 2025
@botelastic botelastic bot added the Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. label Aug 28, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Aug 28, 2025
@cesco-f cesco-f force-pushed the view-in-discover-button branch from d2ce0df to be99fe8 Compare August 28, 2025 07:56
@benakansara
Copy link
Contributor

@cesco-f can we add additional KQL filter for each condition as disabled filters in "View in discover" link? Currently, only count aggregation can have additional KQL filter, but we will add it for other aggregations as well in #231158.

Screenshot 2025-09-01 at 1 10 59 PM

@mgiota mgiota self-requested a review September 1, 2025 11:45
@cesco-f
Copy link
Contributor Author

cesco-f commented Sep 2, 2025

@cesco-f can we add additional KQL filter for each condition as disabled filters in "View in discover" link? Currently, only count aggregation can have additional KQL filter, but we will add it for other aggregations as well in #231158.

Screenshot 2025-09-01 at 1 10 59 PM

Hey @benakansara!

Is this what you had in mind? 0d4a6be

@elasticmachine
Copy link
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #28 / Fleet packages test Automatic agent upgrades should take agents marked and ready for retry into account and upgrade them
  • [job] [logs] Jest Tests #18 / useDiscoverUrl builds Discover url for custom threshold rule including filters
  • [job] [logs] Jest Tests #18 / useDiscoverUrl builds Discover url for custom threshold rule including filters

History

@cesco-f cesco-f self-assigned this Sep 2, 2025
@cesco-f cesco-f force-pushed the view-in-discover-button branch from 0c21e60 to 0d4a6be Compare September 2, 2025 09:04
@mgiota
Copy link
Contributor

mgiota commented Sep 2, 2025

@cesco-f I tested it and works fine. I have a comment regarding responsive view. Not a blocker, but probably something we would need some design input for a follow up.

Screenshot 2025-09-02 at 11 58 25

@cesco-f cesco-f merged commit 2251285 into elastic:main Sep 3, 2025
12 checks passed
@cesco-f cesco-f deleted the view-in-discover-button branch September 3, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:skip This PR does not require backporting release_note:enhancement Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants