[Streams 🌊 ] Improve processing warnings #239188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
Closes: elastic#237023 ## Summary 📚 This PR improves processing warnings by adding truncation logic with wrapping the text so it doesn't go out of the component. ## Additional change ❗ This PR also removes the icon from the warning : <img width="714" height="765" alt="Screenshot 2025-10-16 at 10 59 49" src="https://github.com/user-attachments/assets/967b7870-732e-46fc-a2dc-f89dcad37fb4" /> ## How to Test 🧪 Steps: 1. Streams → Stream details → Processing → Create a Processor( grok for example). 2. Add a pattern that produces warnings. 3. Look for long warnings and check for the truncation logic. ## Demo 🎥 https://github.com/user-attachments/assets/e64d39a5-6849-4b14-b3c0-55c598db5a89 ## Note 📓 I also had an idea of dynamically adjusting truncation based on the size of the warning and adding `useResizeObserver` but I though that's a bit overkill. If you think otherwise I'm happy to discuss about it ! --------- Co-authored-by: kibanamachine <[email protected]>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
Closes: elastic#237023 ## Summary 📚 This PR improves processing warnings by adding truncation logic with wrapping the text so it doesn't go out of the component. ## Additional change ❗ This PR also removes the icon from the warning : <img width="714" height="765" alt="Screenshot 2025-10-16 at 10 59 49" src="https://github.com/user-attachments/assets/967b7870-732e-46fc-a2dc-f89dcad37fb4" /> ## How to Test 🧪 Steps: 1. Streams → Stream details → Processing → Create a Processor( grok for example). 2. Add a pattern that produces warnings. 3. Look for long warnings and check for the truncation logic. ## Demo 🎥 https://github.com/user-attachments/assets/e64d39a5-6849-4b14-b3c0-55c598db5a89 ## Note 📓 I also had an idea of dynamically adjusting truncation based on the size of the warning and adding `useResizeObserver` but I though that's a bit overkill. If you think otherwise I'm happy to discuss about it ! --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #237023
Summary 📚
This PR improves processing warnings by adding truncation logic with wrapping the text so it doesn't go out of the component.
Additional change ❗
This PR also removes the icon from the warning :
How to Test 🧪
Steps:
Demo 🎥
demo-truncate.mov
Note 📓
I also had an idea of dynamically adjusting truncation based on the size of the warning and adding
useResizeObserverbut I though that's a bit overkill. If you think otherwise I'm happy to discuss about it !