Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Update readme.md#183

Closed
AndrewStoyan wants to merge 1 commit into
electron:masterfrom
AndrewStoyan:patch-1
Closed

Update readme.md#183
AndrewStoyan wants to merge 1 commit into
electron:masterfrom
AndrewStoyan:patch-1

Conversation

@AndrewStoyan
Copy link
Copy Markdown

No description provided.

@welcome
Copy link
Copy Markdown

welcome Bot commented Dec 1, 2017

Thanks for opening your first pull request on this repo!
Note that translations should be made on Crowdin and should not be submitted manually here as a pull request.
Please check out our contributing guidelines.
🙏

@zeke
Copy link
Copy Markdown
Contributor

zeke commented Dec 1, 2017

Thanks for the fix, @AndrewStoyan. Out of curiosity, can you explain the difference between "українська мова" and "українська"?

I'm happy to merge this, but I'm afraid the next time we run this script, the label will revert to its old value, as this label is derived from locale-code > iso-639-1-zh -> iso-639-1

~/git/electron/electron-i18n master
$ npm ls iso-639-1
electron-i18n@0.0.0-development /Users/z/git/electron/electron-i18n
└─┬ locale-code@1.1.1
  └─┬ iso-639-1-zh@1.0.3
    └── iso-639-1@1.3.0

Here's the exact source:

https://github.com/meikidd/iso-639-1/blob/cad5b4a4022f45912c3b904f7a7f524650d3959a/src/data.js#L684

I would recommend trying to fix this problem at the source, but because the dependency is so deep, it could take ages to actually propagate back to the locale-code module we're depending on.

So.. I would recommend hacking the lib/language-table.js file in this repo to amend the Ukrainian label. Does that make sense?

@AndrewStoyan
Copy link
Copy Markdown
Author

@zeke the difference is more clear if translate that into English. "Українська мова" means "Ukrainian language" and "Українська" means "Ukrainian". So for more consistency of that list, it probably will be better to use "Українська".

Yeah, thanks a lot for that piece of advice.

@zeke zeke mentioned this pull request Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants