Skip to content

Fix headers.link not being parsed.#196

Merged
elwayman02 merged 2 commits into
elwayman02:masterfrom
jabrown85:fix-for-header-link
Sep 27, 2018
Merged

Fix headers.link not being parsed.#196
elwayman02 merged 2 commits into
elwayman02:masterfrom
jabrown85:fix-for-header-link

Conversation

@jabrown85

Copy link
Copy Markdown
Contributor

At some point headers.Link became headers.link

image

I'm assuming an upgrade of something down the line caused this change.

At some point `headers.Link` became `headers.link`
@Dhaulagiri Dhaulagiri added the bug label Sep 27, 2018
@elwayman02

Copy link
Copy Markdown
Owner

Was this a change made on GitHub's end to the response they return?

@jabrown85

Copy link
Copy Markdown
Contributor Author

Was this a change made on GitHub's end to the response they return?

Ember data will eventually merge emberjs/data/#5489 and break this. Also, newer versions of chrome and safari downcase the headers.

@elwayman02
elwayman02 merged commit d3e3551 into elwayman02:master Sep 27, 2018
@Dhaulagiri

Copy link
Copy Markdown
Collaborator

Released in 0.8.1. Thanks @jabrown85 !

@jabrown85
jabrown85 deleted the fix-for-header-link branch September 27, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants