fix(executor): validate download and cache completeness before reuse#251
Open
damilolaedwards wants to merge 1 commit into
Open
fix(executor): validate download and cache completeness before reuse#251damilolaedwards wants to merge 1 commit into
damilolaedwards wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached artifacts were trusted on presence alone, so an incomplete write
could be served as valid indefinitely.
Range downloads ignored io.Copy's byte count, so a 206 body that ended
early left a zero-filled hole in the pre-allocated file with no error.
downloadChunk now verifies it received the full requested range, and the
single-GET path checks the body against the advertised size.
EEST preparation decided the cache was warm from the fixtures directory
existing, but fixtures and genesis extract in two steps. A run interrupted
between them was reused forever with genesis missing. Reuse is now gated on
a completion marker written only after both steps succeed, and a partial
cache is cleared and re-downloaded on the next run.