Skip to content

EFI: Express LTS Strategy #196

Closed
Closed

Description

@wesleytodd

Many decisions on which tools to use, coding patterns to follow, and generally run some technical decisions depend on how we decide to treat Node.js Version support and how to run major version releases. There is one requirement for an LTS strategy for this project:

  1. We must maintain strict Node.js version support within a single express major

There are some really nice to haves:

  1. Keeping our version support modern so we don't block node core from making progress
  2. Keeping our version support modern so we don't get old outdated bug reports or security issues
  3. Keeping our version support modern so we can adopt newer patterns faster

And then there are a lot of things to discuss around the cost and priorities of these things. I think we need to have this discussion, and I was waiting on things getting sorted more generally, but to keep the conversations focused I am opening this issue now so folks can centralize the conversation someplace without rehasing it in many different dependent issues like #184.

Activity

  1. ljharb commented on Feb 24, 2024

    @ljharb
    Contributor

    Keeping our version support modern so we don't block node core from making progress

    This merely requires continually testing on all supported versions of node, which both myself and pkgjs have actions to help you dynamically create a matrix for.

    Keeping our version support modern so we don't get old outdated bug reports or security issues

    I'm not sure what this means - as long as modern node is supported, a bug on an older supported version of node is still a bug.

    Keeping our version support modern so we can adopt newer patterns faster

    this really only applies to syntax, and that can be transpiled, so it needn't be a forcing function most of the time.


    One of the inherent negative costs of any major bump is that people will be left behind on the old major, and backports for bug and security fixes become much more annoying and unlikely. When a major bump drops support for an engine, it makes upgrade the platform for that user much harder. I strongly suggest not arbitrarily adhering to someone else's support plan (LTS, eg) and instead, decide which node versions to support based on what minimal featureset is needed for express to support the user patterns it wants, and no fewer.

    In the event that a dependency has a tighter contraint than express otherwise needs to impose, the tradeoffs should be ad-hoc weighed between letting that dependency make decisions for this project, vs the cost of finding an alternative dependency. (in most cases, i'll be happy to maintain an alternative dependency if that resolves this question)

  2. kibertoad commented on Feb 25, 2024

    @kibertoad
    Contributor

    this really only applies to syntax, and that can be transpiled

    Transpilation is not the best approach for a framework, as that can cause unpredictable runtime overhead in some cases, especially when transpiling to a much older version. And it complicates debugging significantly.

  3. kibertoad commented on Feb 25, 2024

    @kibertoad
    Contributor

    @ljharb If the approach is to base supported version on desired libraries / syntax, it might make sense to start forming a wishlist for these. I'll start:

    1. Modern testing library. My personal recommendation would be vitest, which requires node 18+, which is roughly similar to native Node test runner
    2. Modern validation library. Typebox is Node 16+
    3. Async/await (Node 8+)
    4. Async iterators (Node 10+)
    5. Optional chaining and nullish coalescence (Node 14+).

    That to me looks like 18 would be great, and Node 14 would be a bare minimum.
    What are the alternatives if Node 18 is too high of a bar? Minimalistic stuff like tap?

  4. ljharb commented on Feb 25, 2024

    @ljharb
    Contributor

    You say “minimalistic” like it’s not one of the strongest arguments to consider a tool.

  5. kibertoad commented on Feb 25, 2024

    @kibertoad
    Contributor

    @ljharb It's subjective, of course, but I would take DX over minimalism any day. Adjustable height table that you control by a handle mechanically is minimalistic, but pressing the button to adjust the height is so much faster and more convenient.

    If I can get away with not doing something by hand in coding with no runtime drawbacks, I will. And experience of using TAP in IDEs is so poor, I sometimes want to scream when debugging failing tests for fastify libs. And uncomfortable tooling = less outside contributors.

    What are the advantages of minimalistic tooling? It's not even about learning curve, because sometimes it's even steeper as a result of having less convenience features available.

  6. ljharb commented on Feb 25, 2024

    @ljharb
    Contributor

    Those were the same arguments that supported using jest, and the reasons most people are trying to move away from jest now are the same reasons I’d give.

  7. kibertoad commented on Feb 25, 2024

    @kibertoad
    Contributor

    @ljharb No, problem with Jest wasn't that it had poor DX. Actually, its API was so good, that both vitest and bun pretty much copied it verbatim, and it still hold up well. Problems with jest was that it
    a) monkey-patched a lot of stuff that it shouldn't have
    b) was abandoned by Meta

  8. ljharb commented on Feb 25, 2024

    @ljharb
    Contributor

    Yes, I’m saying that the very good DX actually hid a lot of the complexity that turned out to be the root of the unavoidable problem. By avoiding that complexity, even at the cost of some DX, you save years of dev time later. My tape tests have never once needed any significant migration on 500 projects, over a decade ¯\_(ツ)_/¯

  9. kibertoad commented on Feb 25, 2024

    @kibertoad
    Contributor
    By avoiding that complexity, even at the cost of some DX, you save years of dev time later
    

    Not necessarily. We've migrated our tests from Jest to Vitest without any changes, other than renaming jest. to vitest. and changing the config file. That's a one time migration effort, and then I'm saving time and energy every day.

    It's somewhat strange to say that walking is superior to a car because you never need gasoline for it. That's technically true, but tradeoffs involved are way deeper than that.

  10. kibertoad commented on Feb 25, 2024

    @kibertoad
    Contributor

    My tape tests have never once needed any significant migration on 500 projects, over a decade

    YMMV on that. I definitely had to do more changes to node-tap tests when bumping major versions in fastify codebase than I had to do to migrate from jest to vitest, or when bumping vitest semver major. That's a benefit of a stable, mature and well-designed API - it doesn't need to change.

  11. sheplu commented on Feb 25, 2024

    @sheplu
    Member

    Changing a major version support (removing one) would be for me a breaking changed, and I agree to being tied to another project schedule release can be an issue.
    But we should also work on lowering the need to support a large matrix of versions.

    As posted there #172 it seems that a lot of other framework (and not all) adhere to something close to supporting the major version for the past 3 years which for us would make it between v14 and v16 if we were releasing a new major version today.

    As this discussion is only for Express@5 (we won't change or deprecate versions supported by Express@4) we should discuss about that.
    From what @kibertoad was also mentioning this would be quite close - and allow some "new" tooling

  12. ljharb commented on Feb 26, 2024

    @ljharb
    Contributor

    If there is concrete difficulty in supporting a particular version ("having to run CI on it" doesn't count), or a concrete feature needed (the "exports" field, native ESM for some reason, async/await syntax, etc), then it makes perfect sense to constrain the supported versions accordingly. "it's old" is not a sensible reason, nor is "people who aren't us don't support it", is all.

  13. added
    top priorityIssues which the TC deem our current highest priorities for the project
    on Feb 26, 2024
  14. wesleytodd commented on Feb 26, 2024

    @wesleytodd
    MemberAuthor

    I think this conversation is a great example of where some agree upon technical priorities would help. I think my ideal is that we find a good happy medium. Yes that means we might drop node versions for sometimes "arbitrary" reasons but IMO we should value "predictable schedule" over "maximal version support" (phrasing might not be great, but the I hope that gets the point across). That doesn't mean we don't value version support, just that we want predictable timelines more than we want to support older versions.

  15. ljharb commented on Feb 26, 2024

    @ljharb
    Contributor

    Why is that beneficial?

  16. 23 remaining items

  17. wesleytodd commented on Feb 29, 2024

    @wesleytodd
    MemberAuthor

    Probably sent that too soon.

    Only keeping express 5 for a few months is not something that we can do, it would hurt the ecosystem.

    Yeah I think we will be stretched thin even with both majors for a year. I agree and think we should try and commit to supporting v5 for two years. Think about the transition here, folks are not at all used to having major updates, so we may have a really long tail of updates here. Just because we have excitement (which is awesome) we should make sure we dont hurt the ecosystem with our efforts.

    So without giving a timeline, if we were releasing express 5 today

    And to address this point from @sheplu, I totally agree the schedule and docs should explicitly cover how long security release will be done (I feel like this was partially covered but I dont have the doc in front of me).

  18. kibertoad commented on Feb 29, 2024

    @kibertoad
    Contributor

    Very fair points. Waiting two years after v5 lands sounds overly long, however. What do you think about Node model, with non-LTS odd releases that are only supported for one year, and even LTS releases with a 2 year support?

  19. wesleytodd commented on Feb 29, 2024

    @wesleytodd
    MemberAuthor

    Very fair points. Waiting two years after v5 lands sounds overly long, however.

    Yeah, I am not sure I feel like we would do 2 years for ever, but having to roll out node LTS version at work I can say that for larger orgs longer is for sure better. Even the Node LTS schedule is too fast for Netflix and I imainge there are many orgs with even tighter restrictions and slower pace.

    What do you think about Node model, with non-LTS odd releases that are only supported for one year, and even LTS releases with a 2 year support?

    I do sort of like this. I can get on board if we could call v5 special and ear mark it for longer support while also saying we would do 1 major a year (max) for the rest with an alternating LTS version every other.

  20. kibertoad commented on Feb 29, 2024

    @kibertoad
    Contributor

    Agree that there are big corpos that move slow, but I wouldn't artificially slow down releases for their sake. Existence of a release doesn't mean they must upgrade. For that matter, having two separate releases with half the breaking changes in each make more incremental updates possible, which is typically easier and less risky.

  21. jonchurch commented on Feb 29, 2024

    @jonchurch
    Member

    I have so many opinions and cannot capture them all right now.

    I am not caught up on the thread entirely so apologies if Im retreading.

    Specifically to cadence of bringing innovation:

    can we consider a "future flag" approach? One LTS version active, one "next" version under development, bring stable features from "next" to LTS behind feature flags. Consumers can use future looking features in production, if they are bold, without having to wait for the next major to cut. When it cuts, they drop the feature flags and either don't have to rewrite any code, or have to rewrite less bc they are on the newer API already.

    I think Remix does this. It is maintenance burden FOR SURE, but if we can pull it off it's like magic ✨✨

  22. ljharb commented on Feb 29, 2024

    @ljharb
    Contributor

    Existence of a release doesn't mean they must upgrade

    while this is technically correct

    image

    … in practice this means that they'll be screwed out of security updates and bugfixes, since backports are annoying enough that they're rarely done.

    Regardless, I would strongly suggest (as much as is feasible) requiring all breaking changes to be shipped non-breaking, behind an option, and to have the next major simply flip the default (ideally, preserve both behaviors), since that makes updates much easier and less risky.

  23. kibertoad commented on Feb 29, 2024

    @kibertoad
    Contributor

    @ljharb LTS strategy explicitly requires backporting important fixes to all maintained LTS lines.

    +1 on shipping breaking changes under a flag. Can someone make a PR adding that to the doc?

  24. wesleytodd commented on Feb 29, 2024

    @wesleytodd
    MemberAuthor

    I wouldn't artificially slow down releases for their sake

    I am not saying artificially slow things down, but that is not itself a clear direction. I think the goal is a pace which balances both for us maintainers and our variety of users. If 2 years is the right pace for enterprise and 6 months is the right pace for hobbyists who want to use bleeding edge features we should shoot for the goldilocks zone.

    For that matter, having two separate releases with half the breaking changes in each make more incremental updates possible, which is typically easier and less risky.

    Yep! But the key is that that incremental thing cannot mean shorter support of security and bug fixes. That's the balance.

    can we consider a "future flag" approach?

    We can!! But there is a lot to consider with that and it will matter what the feature is. So I think we shouldn't hinge this decision based on if or if not we do feature flagging. And this is basically what @ljharb said right after:

    requiring all breaking changes to be shipped non-breaking, behind an option

    So with that I think we should "Can someone make a PR adding that to the doc?" as @kibertoad said.

  25. self-assigned this
    on Mar 1, 2024
  26. wesleytodd commented on Apr 10, 2024

    @wesleytodd
    MemberAuthor

    I have not updated this thread in a bit, but I think my position has changed. After many discussions I believe my tipping point on this issue is the following:

    Nothing today is stopping folks on v4 from using latest Node.js versions. Additionally, nothing we would change in v5 would block them either.

    This means that "dropping support" for these node versions does not impact their ability to upgrade.

    And to that point, this is what I am going into our discussion today for the working session thinking:

    1. I propose we keep running the tests for old node versions until they start failing
    2. I propose we set an engines field which is maximally permissive in v5 but plan to strongly restrict it with v6
    3. I propose we explicitly document that starting with v5 we only "support" node LTS lines at the time of release (and we need to clearly define what support means, as per all the comments above)

    I think after we discuss in today's meeting we need to move all this stuff into the doc @kibertoad started in #199. But after that I hope we can close this issue out and start acting on this goal.

  27. ljharb commented on Apr 10, 2024

    @ljharb
    Contributor

    It impacts their ability to upgrade if other things are keeping them stuck on old node versions, which is often the case for many applications - think sass, gulp, and anything using C++. There's a reason that node 16 and 14's usage, each, are larger than node 18's downloads, and node 12 has more downloads than any of node 19+ combined.

  28. wesleytodd commented on Apr 10, 2024

    @wesleytodd
    MemberAuthor

    Yeah this was my original concern, but similar to what I said above with "that is node.js' job" I think "that is sass/gulp/etc's job". Nothing we do here will stop them from keeping on Express v4 for the next few years, and since we are not going to out of our way to break them I don't see us gaining anything from this "lowest common denominator" approach (us or our users stuck in the way described). As in, nothing we do will help them either way afaict.

  29. UlisesGascon commented on Apr 11, 2024

    @UlisesGascon
    Member

    I created a PR to land the changes expect from our last TC meeting expressjs/express#5595

  30. wesleytodd commented on Mar 28, 2025

    @wesleytodd
    MemberAuthor

    I attempted to consolidate and complete some of this in an ADR form. I tried to pull from this one and a bunch of other sources to make a hopefully complete proposal. So I am going to close this one out, so we can hopefully move all the conversation to one place going forward.

    That said, if I missed anything from here please help me find and add it there because there is a lot of conversation and I am sure I probably missed something of it in my attempt to re-read and consolidate it.

    #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

top priorityIssues which the TC deem our current highest priorities for the project

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions