You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Consider disabling extended query string parsing by default #3361
I created a simple browser-based XSS filter test app here: http://xss.untrusted.com/xss?id=aaa&id=bbb
This is page is simple enough that pretty much any filter bypass bug present here would be legitimate. That is, the identified bypass condition would have to be in-scope as an issue for the filter to defend against.
I was able to fix my test app by manually disabling the extended query string parsing:
app.set('query parser', 'simple');
While it's certainly not the responsibility of express to make the IE / Edge XSS Filter's job any easier, disabling the extended query parsing by default would be one way to solve this issue for the filter.
Yes, the plan is to disable by default in Express 5.0. You can view the 5.0 plan here: #2237
Make query parser option default to 'simple'
I hope this helps! I even updated the plan to reference this issues in the check list for that entry, since there wasn't a specific issue before that I recall, just discussions.
Activity
dougwilson commentedon Jul 11, 2017
Yes, the plan is to disable by default in Express 5.0. You can view the 5.0 plan here: #2237
I hope this helps! I even updated the plan to reference this issues in the check list for that entry, since there wasn't a specific issue before that I recall, just discussions.
randomdross commentedon Jul 11, 2017
Oh that's awesome! Thank you Doug!
dougwilson commentedon Jul 11, 2017
And the
body-parsermodule has the same thing, which is also being defaulted off in it's 2.0 release.Change query parser setting default to `'simple'`
dougwilson commentedon Dec 18, 2021
Everything has now been updated to default to the simple parser in the current 5.0 branch 👍
Change query parser setting default to 'simple'