You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Node.js 15+ starts recommending promise based versions by default - Express 5.0 and wrapAsync #4535
Express 5.0 has added automatic handling in routes of async/await routes that will automatically invoke the Express error handler if a an async function throws. There are current workarounds to create a wrapAsync() function around routes, but in bigger projects some users miss this and it's also not-so-nice-looking (and confusing for some).
I am merely wondering if Express 5.0 could be released, and current items on https://github.com/expressjs/express/milestone/11 could be moved to a 6.0 release? I am very respectful of the fact that you voluntarily work on this, and these kind of questions are frowned upon. #2237 was created 7 years ago now, so I at least think it should be ok to ask for this without in any way not being grateful of this project already and its release cadence.
I guess what I am saying is that there are some nice things already on the main branch for Express 5.0 that works good with latest versions of Node.js 15, so a release would be amazing.
Reacted by Romain Lenzotti, Aravind Nair, Yurii Holskyi, Hannah Coard, Michael Rotarius, Marenda SA, David Enyoghasim, Drew Schulz, Ernesto Alejo, Marek Krajčovič and 26 more
@enyoghasim I am no maintainer of this repo and do not have the power to do releases, so I am unsure why I was added as asignee? Considering you are part of the express organization, is there any chance you could rally your peers to look into this?
@dougwilson do you have anything to add to this? You are certainly doing a great job with maintenance of all the subdependencies etc of Express. But if Express 5.0 alpha 8 has not received any complaints of serious bugs, what are you feeling about this topic?
Also the answer by @enyoghasim concerns me a bit: I am not sure if it is sarcasm or what, but yeah.
Hi @thernstig I'm sorry for one of the comments in the thread; I went ahead a hid it for now.
As for your idea, that is pretty much what the TC decided, even though there is still a lot of flac from the community about deferring things like http/2 to express 6. Really, there is only one outstanding issues for express 5, and it is related to async/await in the router. There is an open PR to address this, but the author has kind of faded away. Ideally that's really all that needs to be fixed if the idea is for express 5's main goal to be async/await.
@dougwilson thank you very much for answering, I know you have a very busy schedule.
Any chance you could champion taking over that PR to get it merged?
I agree with you and the TC. I think it is perfectly fine to release 5.0 and then later HTTP/2. There is always some "can you just add this as well?". I personally do not think there is anything stopping release 6 being a much smaller release with just having HTTP/2 as the main focus. That way it really should not matter much to users who want HTTP/2 get an "intermediate" 5.0 release.
I feel the same way as @filipecatraia, having tried Koa but moved back to express for similar reasons. I would also prefer not to have to wrap all of my request handlers in asyncHandler.
@aravindvnair99 those links do not help much I am afraid. @dougwilson stated there was only one outstanding issue for 5.0. Meaning it seems the rest could be postponed.
It is clear @dougwilson is very active on Github, and seeing there is only one outstanding issue for the release, it feels natural to focus on that PR i.e. take over what the original author of that PR started. The focus seems to be on updating other things, which maybe could be held of till that one thing stopping Express 5.0?
The community has been waiting for many years quite patiently for the release, and has helped along the way with PRs and issues. It would be great to finally after these years make the community happy with a new release 😃
Reacted by Jane Jeon, Cody Ebberson and Karl Holub
@thernstig I agree. My intention though was just to mention the links here for anyone else who stumbles upon this issue tracker.
I must admit I too am excited for a v5 release. Express has always been about stability in my opinion, but yes I look forward to v5. It's long been in the development stage.
And as for what @dougwilson was referring to, I'm not sure which issue that is exactly. My guess are on this one: #4321
@dougwilson, could we get some feedback from you? Asking with my nicest voice possible, is there no chance you could fix the last outstanding problem if you know what to do? It feels every time this is brought up lots of other things are fixed instead of this. I am unsure why, it almost feel like releasing 5.0 is shunned for some reason 😞
The author of the PR is back with us and was just working on it the other day. When someone is working on aomething, I don't feel it would be appropriate if I just did it myself and then pushed my own code and then closed their PR, would you? I don't think that would be a great way to keep people contributing. Since they are now interacting with the PR to finiah it, I think that is fine.
@aravindvnair99 is a triager and even provided various links here. We have the triagees so, among other things, I don't have to respond to every single comment across all the repos and can do other tasks.
Activity
enyoghasim commentedon Mar 15, 2021
thernstig commentedon Mar 15, 2021
@enyoghasim I am no maintainer of this repo and do not have the power to do releases, so I am unsure why I was added as asignee? Considering you are part of the express organization, is there any chance you could rally your peers to look into this?
thernstig commentedon May 17, 2021
@dougwilson do you have anything to add to this? You are certainly doing a great job with maintenance of all the subdependencies etc of Express. But if Express 5.0 alpha 8 has not received any complaints of serious bugs, what are you feeling about this topic?
Also the answer by @enyoghasim concerns me a bit: I am not sure if it is sarcasm or what, but yeah.
dougwilson commentedon May 17, 2021
Hi @thernstig I'm sorry for one of the comments in the thread; I went ahead a hid it for now.
As for your idea, that is pretty much what the TC decided, even though there is still a lot of flac from the community about deferring things like http/2 to express 6. Really, there is only one outstanding issues for express 5, and it is related to async/await in the router. There is an open PR to address this, but the author has kind of faded away. Ideally that's really all that needs to be fixed if the idea is for express 5's main goal to be async/await.
thernstig commentedon May 17, 2021
@dougwilson thank you very much for answering, I know you have a very busy schedule.
Any chance you could champion taking over that PR to get it merged?
I agree with you and the TC. I think it is perfectly fine to release 5.0 and then later HTTP/2. There is always some "can you just add this as well?". I personally do not think there is anything stopping release 6 being a much smaller release with just having HTTP/2 as the main focus. That way it really should not matter much to users who want HTTP/2 get an "intermediate" 5.0 release.
Articles like https://dev.to/romainlanz/why-you-should-drop-expressjs-in-2021-711 make me sad because 1) much of the article is not true 2) Express is being actively worked on but some people do not explore enough to be aware it is.
enyoghasim commentedon May 17, 2021
@dougwilson @thernstig i am sorry for the hidden comment
euoia commentedon May 19, 2021
I feel the same way as @filipecatraia, having tried Koa but moved back to express for similar reasons. I would also prefer not to have to wrap all of my request handlers in
asyncHandler.@dougwilson you said:
Would you mind linking to the issue in this thread for anybody else following along who might like to take a shot at it?
thernstig commentedon Jun 1, 2021
@dougwilson, could you share the only issue holding off the release?
aravindvnair99 commentedon Jun 6, 2021
Leaving a few useful links here:
thernstig commentedon Jun 6, 2021
@aravindvnair99 those links do not help much I am afraid. @dougwilson stated there was only one outstanding issue for 5.0. Meaning it seems the rest could be postponed.
It is clear @dougwilson is very active on Github, and seeing there is only one outstanding issue for the release, it feels natural to focus on that PR i.e. take over what the original author of that PR started. The focus seems to be on updating other things, which maybe could be held of till that one thing stopping Express 5.0?
The community has been waiting for many years quite patiently for the release, and has helped along the way with PRs and issues. It would be great to finally after these years make the community happy with a new release 😃
aravindvnair99 commentedon Jun 6, 2021
@thernstig I agree. My intention though was just to mention the links here for anyone else who stumbles upon this issue tracker.
I must admit I too am excited for a v5 release. Express has always been about stability in my opinion, but yes I look forward to v5. It's long been in the development stage.
And as for what @dougwilson was referring to, I'm not sure which issue that is exactly. My guess are on this one: #4321
thernstig commentedon Jul 1, 2021
@dougwilson, could we get some feedback from you? Asking with my nicest voice possible, is there no chance you could fix the last outstanding problem if you know what to do? It feels every time this is brought up lots of other things are fixed instead of this. I am unsure why, it almost feel like releasing 5.0 is shunned for some reason 😞
dougwilson commentedon Jul 1, 2021
The author of the PR is back with us and was just working on it the other day. When someone is working on aomething, I don't feel it would be appropriate if I just did it myself and then pushed my own code and then closed their PR, would you? I don't think that would be a great way to keep people contributing. Since they are now interacting with the PR to finiah it, I think that is fine.
@aravindvnair99 is a triager and even provided various links here. We have the triagees so, among other things, I don't have to respond to every single comment across all the repos and can do other tasks.
dougwilson commentedon Feb 17, 2022
A beta.1 has been released with the referenced router changes 🎉 . Please check it out http://expressjs.com/en/guide/migrating-5.html
Since this changed the route path syntax a bit, I'll let it get maybe a month for feedback before official release.