Conversation
only notable one : writeNCount() resists better vs invalid distributions (though it should never happen within zstd anyway)
exclude zlib code
test run on Linux
so that a different version of scan-build can be selected
terrelln
approved these changes
Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re-enable
scan-buildtests,fixing all issues found in the process.
This test should help us capture automatically some easy mistakes,
such as forgetting to check a
malloc()outcome, forgetting to release resource, etc.which are situations that are typically not triggered at runtime
because they almost never happen, on test systems.