Skip to content

Reset RC per-instance userdefaults if config database was not found. #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 14, 2020
Merged

Reset RC per-instance userdefaults if config database was not found. #4896

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0b37eb2
Reset the RC per-instance user defaults if the config database was no…
dmandar Feb 12, 2020
402288c
Add unit test.
dmandar Feb 12, 2020
66ec97c
Ignore the non-object arguments when stubbing the fetchWithExpiration…
dmandar Feb 14, 2020
39d580e
Update changelog.
dmandar Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ignore the non-object arguments when stubbing the fetchWithExpiration… 
…Duration method.
  • Loading branch information
@dmandar
dmandar committed Feb 14, 2020
commit 66ec97cf8faabec2a685af76cde997eb4d2a3680
3 changes: 2 additions & 1 deletion FirebaseRemoteConfig/Tests/Unit/RCNRemoteConfigTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ - (void)setUp {
namespace:fullyQualifiedNamespace
options:currentOptions]);

OCMStub([_configFetch[i] fetchConfigWithExpirationDuration:43200 completionHandler:OCMOCK_ANY])
OCMStub([_configFetch[i] fetchConfigWithExpirationDuration:0 completionHandler:OCMOCK_ANY])
.ignoringNonObjectArgs()
.andDo(^(NSInvocation *invocation) {
void (^handler)(FIRRemoteConfigFetchStatus status, NSError *_Nullable error) = nil;
[invocation getArgument:&handler atIndex:3];
Expand Down