Remove boolean options fallback#150
Merged
bilelmoussaoui merged 1 commit intoAug 25, 2023
Merged
Conversation
Member
|
oh, good catch |
Member
|
i wonder why the ncc build diff is so huge this time |
Contributor
Author
|
66764d4 to
bc60dce
Compare
Contributor
Author
|
I think I found the issue, I think need to use Edit: I'm really not used to JS development. |
While unnecessary since all of them have a default value Having build-bundle set to false was is fact turning it to true through the fallback
bc60dce to
f1abcd3
Compare
Contributor
Author
|
Dist files should be fixed and good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While unnecessary since all of them have a default value
Having build-bundle set to false was is fact turning it to true through the fallback