refactor: omit unnecessary reassignment

[rifeplight]

Tracking issue

Why are the changes needed?

The new version of Go has been optimized, and variables do not need to be reassigned.

For more info: https://tip.golang.org/wiki/LoopvarExperiment#does-this-mean-i-dont-have-to-write-x--x-in-my-loops-anymore

What changes were proposed in this pull request?

How was this patch tested?

Labels

Please add one or more of the following labels to categorize your PR:

• added: For new features.
• changed: For changes in existing functionality.
• deprecated: For soon-to-be-removed features.
• removed: For features being removed.
• fixed: For any bug fixed.
• security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

• I updated the documentation accordingly.
• All new and existing tests passed.
• All commits are signed-off.

Related PRs

Docs link

Summary by Bito

• This pull request refactors the code to eliminate unnecessary variable reassignments across several files, which may introduce risks related to code maintainability.
• The changes enhance code readability and maintainability by leveraging optimizations in the latest version of Go.
• The modifications primarily affect test files and utility functions, ensuring adherence to best practices without altering existing functionality.
• Overall, the changes touch on code structure and readability, introducing potential risks in maintainability.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.90%. Comparing base (3d2932a) to head (dc2e80d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6768      +/-   ##
==========================================
- Coverage   56.91%   56.90%   -0.01%     
==========================================
  Files         929      929              
  Lines       58081    58077       -4     
==========================================
- Hits        33055    33051       -4     
  Misses      21985    21985              
  Partials     3041     3041              

Flag	Coverage Δ
unittests-datacatalog	53.51% <ø> (ø)
unittests-flyteadmin	53.02% <ø> (-0.01%)	⬇️
unittests-flytecopilot	43.06% <ø> (-0.11%)	⬇️
unittests-flytectl	64.02% <ø> (ø)
unittests-flyteidl	75.71% <ø> (ø)
unittests-flyteplugins	60.13% <ø> (-0.01%)	⬇️
unittests-flytepropeller	53.54% <ø> (ø)
unittests-flytestdlib	63.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Sovietaced]

@rifeplight Can you fix the unit test failures?

[rifeplight]

/retest

[rifeplight]

@Sovietaced Modified. Please review it again.

[flyte-bot]

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

[welcome]

Congrats on merging your first pull request! 🎉