Skip to content

Conversation

@Sovietaced
Copy link
Member

@Sovietaced Sovietaced commented Dec 23, 2025

Tracking issue

Closes #6772

Why are the changes needed?

The unit test uses a static assertion of a time format that includes local zone information which fails for non UTC machines.

What changes were proposed in this pull request?

Update the unit test to dynamically create expected value.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped - Draft PR

Bito didn't auto-review because this pull request is in draft status.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change draft PR review settings here, or contact your Bito workspace admin at [email protected].

@Sovietaced Sovietaced added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Dec 23, 2025
@Sovietaced Sovietaced marked this pull request as ready for review December 23, 2025 02:20
@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.94%. Comparing base (002321e) to head (a2b68aa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6812      +/-   ##
==========================================
+ Coverage   56.93%   56.94%   +0.01%     
==========================================
  Files         929      929              
  Lines       58139    58139              
==========================================
+ Hits        33100    33106       +6     
+ Misses      21998    21992       -6     
  Partials     3041     3041              
Flag Coverage Δ
unittests-datacatalog 53.51% <ø> (ø)
unittests-flyteadmin 53.14% <ø> (+0.03%) ⬆️
unittests-flytecopilot 43.06% <ø> (ø)
unittests-flytectl 64.02% <ø> (ø)
unittests-flyteidl 75.71% <ø> (ø)
unittests-flyteplugins 60.13% <ø> (ø)
unittests-flytepropeller 53.54% <ø> (ø)
unittests-flytestdlib 63.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@machichima machichima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Tried locally and the test passed

image

@machichima
Copy link
Member

machichima commented Dec 23, 2025

It's weird that the CI failed. Seems unrelated to this PR

@Sovietaced
Copy link
Member Author

It's weird that the CI failed. Seems unrelated to this PR

Yeah. I don't really understand the error. Not clear if it's a rate limit under the hood or something.

@Sovietaced Sovietaced merged commit fba30ad into flyteorg:master Dec 23, 2025
49 of 52 checks passed
@Sovietaced Sovietaced deleted the issue-6772 branch December 23, 2025 02:55
@flyte-bot
Copy link
Collaborator

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

housekeeping Issues that help maintain flyte and keep it tech-debt free

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ray_test fails locally due to timezone issues

3 participants