-
Notifications
You must be signed in to change notification settings - Fork 767
Fix issue with assertions with time zones #6812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jason Parraga <[email protected]>
|
Bito Automatic Review Skipped - Draft PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6812 +/- ##
==========================================
+ Coverage 56.93% 56.94% +0.01%
==========================================
Files 929 929
Lines 58139 58139
==========================================
+ Hits 33100 33106 +6
+ Misses 21998 21992 -6
Partials 3041 3041
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
machichima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
It's weird that the CI failed. Seems unrelated to this PR |
Yeah. I don't really understand the error. Not clear if it's a rate limit under the hood or something. |
|
Bito Automatic Review Skipped – PR Already Merged |

Tracking issue
Closes #6772
Why are the changes needed?
The unit test uses a static assertion of a time format that includes local zone information which fails for non UTC machines.
What changes were proposed in this pull request?
Update the unit test to dynamically create expected value.
Check all the applicable boxes
Related PRs
Docs link