Use SystemPath for DirectoryWatcher - #20
Closed
chrisgeo wants to merge 0 commit into
Closed
Conversation
chrisgeo
force-pushed
the
feat/chaos-1450-directory-watcher
branch
from
May 8, 2026 22:15
849d310 to
4c1477d
Compare
3 tasks
chrisgeo
force-pushed
the
feat/chaos-1450-directory-watcher
branch
from
May 9, 2026 23:16
9e19473 to
4c1477d
Compare
chrisgeo
force-pushed
the
feat/chaos-1450-directory-watcher
branch
from
May 13, 2026 00:38
642f782 to
b466959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts
DirectoryWatcherfromURLtoSystemPackage.FilePath, mirroring the pattern landed in apple#1480 (HostDNSResolver) and apple#1518 (PacketFilter).Changes
directoryURL: URL→directoryPath: FilePath(public API)init(directoryURL:, log:)→init(directoryPath:, log:)startWatching(handler:)closure signature:([URL])→([FilePath])LocalhostDNSHandler.swiftcaller updated; theURL(filePath: configPath.string)wrapping shim is no longer neededBehavioral note
URL.lastPathComponentreturnsString;FilePath.lastComponentreturnsFilePath.Component?(optional). The filename filter inLocalhostDNSHandlerhandles the optional explicitly via$0.lastComponent?.string.starts(with: ...) == true. This preserves the prior "skip malformed entries" behavior.Context
Test plan
swift test --filter DirectoryWatcherTest— all tests passswift test --filter ContainerOSTests— full module passes (no neighbor regressions)