A dice rolling simulation script #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A beginner project for people wanting an example of how you can use while loops, and random. Key parts of the code is commented, may comment more later to help explain. I am a little new to Python myself, so please feel free to let me know of any better techniques I can use!
mam8
reviewed
May 31, 2017
| #Checking the user input to start the program. | ||
| while correct_word == False: | ||
|
|
||
| user_input_raw = raw_input("\r\nWelcome to the Dice Rolling Simulator! We currently support 6, 8, and 12 sided die! Type [start] to begin!\r\n?>") |
There was a problem hiding this comment.
The prompt string is too long for one line. You may have a variable named prompt_str, and use () to limit characters number.
There was a problem hiding this comment.
Sooo dramtic the words you uesd!!
mam8
reviewed
May 31, 2017
| else: | ||
| print "\r\nPlease choose one of the applicable options!\r\n" | ||
|
|
||
| #Another inner while loop. This one does the actual rolling, as well as allowing the user to re-roll without restarting the program. |
There was a problem hiding this comment.
separate the comment to multiple lines because it's too long.
mam8
reviewed
May 31, 2017
| while dicer == False: | ||
|
|
||
| if user_dice_chooser == 6: | ||
| dice_6 = random.randint(1,6) |
There was a problem hiding this comment.
It seems there are too many duplicated codes, could you abstract them (line 68~ 79, line 53~64, etc) to a function.
UncleAnson
reviewed
Jun 2, 2017
| roller_loop = True | ||
|
|
||
| print "Thanks for using the Dice Rolling Simulator! Have a great day! =)" | ||
|
|
There was a problem hiding this comment.
all right.Good job! but too many dulplicated contents you know,like another reviewer said.
|
Thank you for you contribution to the repo and the community
…On 28 May 2017, at 03:33, SlimxShadyx ***@***.***> wrote:
A beginner project for people wanting an example of how you can use while loops, and random.
Key parts of the code is commented, may comment more later to help explain.
I am a little new to Python myself, so please feel free to let me know of any better techniques I can use!
You can view, comment on, or merge this pull request online at:
#170
Commit Summary
A dice rolling simulation script
File Changes
A dice_rolling_simulator.py (96)
Patch Links:
https://github.com/geekcomputers/Python/pull/170.patch
https://github.com/geekcomputers/Python/pull/170.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks for merging and all the tips! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A beginner project for people wanting an example of how you can use while loops, and random.
Key parts of the code is commented, may comment more later to help explain.
I am a little new to Python myself, so please feel free to let me know of any better techniques I can use!