Various Improvements #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PythonProdigy
commented
Dec 15, 2015
- Removed a redundant function call
- Added exception handling to the file open function
1. Removed a redundant function call 2. Added exception handling to the file open function
UncleAnson
reviewed
Jun 2, 2017
| print line | ||
| except IOError: | ||
| print 'Error opening the file' |
There was a problem hiding this comment.
Here you forget to close the file after "read" it.Could we add a "finally" syntax ?And what if I read a file which is up to several G and may make it out of memory ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.